Bug 438357 - breeze-dark window header and title colours erroneous
Summary: breeze-dark window header and title colours erroneous
Status: RESOLVED INTENTIONAL
Alias: None
Product: Breeze
Classification: Plasma
Component: general (show other bugs)
Version: 5.21.5
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-09 19:41 UTC by Oliver Freyermuth
Modified: 2021-09-20 22:01 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Mismatched decoration and menu bar colours, unclear active / inactive window colours. (404.38 KB, image/png)
2021-06-09 19:41 UTC, Oliver Freyermuth
Details
kdeglobals exhibiting the colour issue (5.25 KB, text/plain)
2021-06-14 17:25 UTC, Oliver Freyermuth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Freyermuth 2021-06-09 19:41:57 UTC
Created attachment 139165 [details]
Mismatched decoration and menu bar colours, unclear active / inactive window colours.

SUMMARY
After upgrading kde-frameworks (5.80 => 5.82) and kde-plasma (5.20.5 => 5.21.5), the title text colour does not change anymore for active / inactive windows and the colours of the menu bar (e.g. of Konsole) and the window decoration does not match anymore for active windows. 

Note that, effectively, this means the window title bar has higher contrast (between text and decoration colour) for inactive windows than for active windows. 

Note I use kde-apss in 20.12.3 in case it matters. 


STEPS TO REPRODUCE
Upgrade versions as outlined above. 

OBSERVED RESULT
See attached screenshot:
1. Colours between window decoration and menu bar are mismatched for the active window. 
2. The active window and the inactive window are almost indistinguishable (only window decoration is slightly changed). The title bar text colour is not changed. 

EXPECTED RESULT
Menu bar and window decoration colour to match, clearly distinguishable active / inactive windows (I believe the title text colour was changed in the past). 

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Gentoo Linux
KDE Plasma Version: 5.21.5 (was 5.20.5 before this issue)
KDE Frameworks Version: 5.82.0 (was 5.80 before this issue)
Qt Version: 5.15.2

ADDITIONAL INFORMATION
If this is an issue due to outdated kde-apps, or an actually planned theme change, feel free to close of course. 
It looks like an unwanted effect to me, hence I suspect a bug and raise this issue. 

I'm using:
- breeze-dark as plasma style.
- breeze-dark as colour scheme.
- breeze for window decorations.
I've already tried switching away and back, to no avail.
Comment 1 Nate Graham 2021-06-09 22:05:41 UTC
You will need to manually switch to another color scheme, and then back to Breeze Light. Sorry about the need for a manual workaround.

*** This bug has been marked as a duplicate of bug 433642 ***
Comment 2 Oliver Freyermuth 2021-06-09 22:19:48 UTC
Thanks!

I tried the following switches:
- from Breeze Dark to regular Breeze and back to Breeze Dark => issue remains
- from Breeze Dark to Breeze Light and back to Breeze Dark => issue remains
- from Breeze Dark to Oxygen and back to Breeze Dark => issue remains

Do I need to switch to a special theme, or clean up kdeglobals manually?
Comment 3 Oliver Freyermuth 2021-06-09 22:57:08 UTC
I compared the [Color*:*] sections betweek
 /usr/share/color-schemes/BreezeDark.colors
and
 ~/.config/kdeglobals
and they are exactly the same, which leaves me at a loss. Is this issue really a duplicate?
Comment 4 Oliver Freyermuth 2021-06-12 15:04:03 UTC
I've reopened this since the proposed workaround does not change the colours, and the colours in ~/.config/kdeglobals match the theme, so it does not seem to be the same issue as in #433642.
Comment 5 Nate Graham 2021-06-14 17:05:38 UTC
Hmm. Can you attach your kdeglobals file (or at least just the section with colors in it)?
Comment 6 Oliver Freyermuth 2021-06-14 17:25:46 UTC
Created attachment 139316 [details]
kdeglobals exhibiting the colour issue

Sure, attached, I only redacted:
 [General] => dbfile
 [DirSelect Dialog] => History Items
Apart from these (which I marked as redacted), it is complete.
Comment 7 Nate Graham 2021-06-14 18:47:38 UTC
Thanks. This is odd. Works for me FWIW.

Any ideas, Jan or Noah?
Comment 8 popov895 2021-07-01 18:00:35 UTC
Try to clear plasma cache (`rm -r ~/.cache/plasma*`).
Comment 9 Oliver Freyermuth 2021-07-01 18:17:02 UTC
Thanks for the proposal!
While logged out and in a ral tty, I tried even:
rm -rf ~/.cache
and logged in graphically only afterwards to have a fully fresh start. 

Sadly, it did not affect the visuals in any way.
Comment 10 Nate Graham 2021-09-16 19:35:00 UTC
Is this still happening to you with Plasma 5.22? What about if you switch to another color scheme and then back to Breeze Dark again?
Comment 11 Oliver Freyermuth 2021-09-17 00:16:23 UTC
Sadly, it still happens to me with Plasma 5.22.5, looks exactly the same. 
I also retried switching themes (did that already in 5.21), still no change.
Comment 12 Nate Graham 2021-09-17 21:01:14 UTC
I tried swapping out my kdeglobals file for yours and restarting and everything looks exactly as I would expect.

The menubar not changing colors seems like a separate issue, but the differences in titlebars between active and inactive windows are intentional at this point.

Please open a new bug report about the menubar and/or toolbar background not correctly switching colors when the window changes to inactive nd back (or vice versa), so we can have a more narrowly-tailored bug report. Thanks!
Comment 13 Oliver Freyermuth 2021-09-18 03:05:29 UTC
Thanks for confirming the colour changes are intentional! 

For reference, I have opened the issue about menubar and toolbar background not correctly switching colors when the window changes to inactive and back as separate Bug 442628 . 

If you allow one final question: The main irritation with the titlebar colours for me is that when a window changes from inactive to active, then in the titlebar:
* Brightness increases (which seems intuitive for a dark theme). 
* Contrast decreases (which seems counter-intuitive). 
Earlier Breeze Dark themes adapted the titlebar text colour to ensure contrasr of inactive window titlebars is lower, so both contrast and brightness of the titlebar increased when a window is activated. 

Is this also intentional, or is the titlebar text colour not changing colours anymore (previously used to reduce contrast for inactive titlebars) unintentional? 

I tried asking some non-Linux users (non-representative study of course) using the screenshot attached here, and their identification of the active vs. the inactive window was only 50:50 correct, while it was always correct if both brightness and contrast increased for the active window.
Comment 14 Nate Graham 2021-09-20 21:13:30 UTC
I know it's intentional that the titlebar, toolbar, and menubar backgrounds change for active vs inactive windows. I can't remember whether it's intentional that the titlebar text doesn't change, however. And I can confirm that this affects with the Breeze Light theme as well. It might actually be a bug or oversight. Can you please file a separate bug report for that and cc me (nate@kde.org)? You could even submit a merge request to change/fix it yourself! The color scheme files live here: https://invent.kde.org/plasma/breeze/-/tree/master/colors. It shouldn't be too hard to do, and I can help you if you run into trouble.
Comment 15 Oliver Freyermuth 2021-09-20 21:51:47 UTC
Thanks for confirming that the titlebar colour changes are intentional, but the titlebar text not changing colours might not :-). 
I checked through this bug tracker, and found:
https://bugs.kde.org/show_bug.cgi?id=435905
If I understand correctly, this is basically the issue I also see: In the theme colour schemes, there actually seem to be different text colours for active/inactive title texts, but they these are not honoured anymore when header colours are used (and there are no active/inactive Header group titlebar text colors). 
So it seems the issue I wanted to raise seems to exist already ;-). But an MR to fix this seems to be more complex than an MR changing the colour scheme files.
Comment 16 Nate Graham 2021-09-20 22:01:30 UTC
Aha yup, that's the exact issue.