Bug 438347 - Icons in popup are not aligned when applet names are multi-line strings
Summary: Icons in popup are not aligned when applet names are multi-line strings
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: 5.22.0
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-09 17:51 UTC by Piotr Keplicz
Modified: 2022-03-04 00:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24.3
Sentry Crash Report:


Attachments
Chaotic layout (40.23 KB, image/png)
2021-06-09 17:51 UTC, Piotr Keplicz
Details
Somewhat fixed in Gimp (43.92 KB, image/png)
2021-06-09 17:52 UTC, Piotr Keplicz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Keplicz 2021-06-09 17:51:23 UTC
Created attachment 139156 [details]
Chaotic layout

SUMMARY

The icons and their labels in the "State and notifications" view of the system tray should assume common baseline for the icons so that their labels start at the same height.

The first attachment show how it looks like for the Polish language.

Also, longer words are wrapped, not clipped. If a word doesn't fit, it could be blended into background perhaps?


STEPS TO REPRODUCE
1. Open "State and notifications".
Comment 1 Piotr Keplicz 2021-06-09 17:52:04 UTC
Created attachment 139157 [details]
Somewhat fixed in Gimp
Comment 2 Nate Graham 2021-06-09 22:43:21 UTC
Can confirm.
Comment 3 Nate Graham 2022-03-04 00:54:44 UTC
Git commit 8fcdfc309fad296b73057d602817b9f595821ace by Nate Graham, on behalf of Michail Vourlakos.
Committed on 04/03/2022 at 00:54.
Pushed by ngraham into branch 'master'.

applets/systray: align applet labels with differing line counts in hidden view

Discover current minimum height of applet labels in hidden
view and apply it for all of them when they are shown
inside hidden applets view. This implementation provides
always only the maximum needed label height based on label
contents.
FIXED-IN: 5.24.3

M  +21   -0    applets/systemtray/package/contents/ui/HiddenItemsView.qml
M  +6    -0    applets/systemtray/package/contents/ui/items/AbstractItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/8fcdfc309fad296b73057d602817b9f595821ace
Comment 4 Nate Graham 2022-03-04 00:55:32 UTC
Git commit 5727362e3666f3d74c641665f5fb86b7d1434216 by Nate Graham, on behalf of Michail Vourlakos.
Committed on 04/03/2022 at 00:55.
Pushed by ngraham into branch 'Plasma/5.24'.

applets/systray: align applet labels with differing line counts in hidden view

Discover current minimum height of applet labels in hidden
view and apply it for all of them when they are shown
inside hidden applets view. This implementation provides
always only the maximum needed label height based on label
contents.
FIXED-IN: 5.24.3


(cherry picked from commit 8fcdfc309fad296b73057d602817b9f595821ace)

M  +21   -0    applets/systemtray/package/contents/ui/HiddenItemsView.qml
M  +6    -0    applets/systemtray/package/contents/ui/items/AbstractItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/5727362e3666f3d74c641665f5fb86b7d1434216