Bug 438299 - extra I18N_EXCESS_ARGUMENTS_SUPPLIED after SMART status page warning
Summary: extra I18N_EXCESS_ARGUMENTS_SUPPLIED after SMART status page warning
Status: RESOLVED FIXED
Alias: None
Product: i18n
Classification: Translations
Component: fi (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Lasse Liehu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-08 23:04 UTC by nttkde
Modified: 2021-06-14 12:24 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
see the picture (82.82 KB, image/png)
2021-06-08 23:04 UTC, nttkde
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nttkde 2021-06-08 23:04:19 UTC
Created attachment 139122 [details]
see the picture

Info Center's SMART Status page warning message has an extra "(I18N_EXCESS_ARGUMENTS_SUPPLIED)" appended to the end.
Finnish locale. In English, the warning message would be something along the lines "SMART firmware is not reporting an error but is showing early signs of malfunction.[]..."
Comment 1 Harald Sitter 2021-06-10 09:29:52 UTC
Incorrect translation, it's missing the listing at the end

#: kcm/package/contents/main.qml:78
msgctxt "@info %1 is a bunch of <li> with the strings from instabilities.cpp"
msgid ""
"<p>The SMART firmware is not reporting a failure, but there are early signs "
"of malfunction. This might not point at imminent device failure but requires "
"longer term analysis. Back up your data and contact the manufacturer of this "
"disk, or replace it preemptively just to be safe.</p><ul>%1</ul>"
msgstr ""
"<p>SMART-varusohjelmisto ei ilmoita virheestä, mutta osoittaa varhaisia "
"merkkejä toimintahäiriöstä. Tämä ei välttämättä tarkoita laitevikaa mutta "
"vaatii pidempikestoista analyysia. Varmista tietosi ja ota yhteyttä levyn "
"valmistajaan tai vaihda se ennaltaehkäisevästi.</p>"
Comment 2 Unknown 2021-06-10 15:13:26 UTC
SVN commit 1602058 by lliehu:

Fix problems in Finnish translation of plasma_disks



 M  +59 -19    plasma_disks.po  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1602058
Comment 3 Lasse Liehu 2021-06-10 15:31:06 UTC
Thanks for the report. The fix should now be in all localization branches and thus be included in the next release.
Comment 4 Ville Aakko 2021-06-13 17:59:02 UTC
I know this is already clsoed, but I believe there may be more in-depth design faults at play here. Just to be clear: does this translation error cause spurious SMART errors for users via KDE Info Center (despite nothing being wrong with their HDD)?

I get this "error", but AFAIK there is nothing wrong with my SMART data on the "affected" disk, as reported by smartctl. The HDD isn't even old (by SMART metrics or my shopping receipt date). But maybe I'm wrong?

IMHO it is very bad practice to make a monitoring application which makes spurious alerts with as strong as wordings as this one, or alerts which don't point to any logs or more information as to what is wrong. In this case it causes unbased worries for users, or in worst case, people changing working hardware; or losing trust on "alerts" (wrong alerts cause correct alerts to not cause reaction on end-users).

The application should have a "more info" -button to show the output it thinks is the cause for these "early signs of malfunction".
Comment 5 nttkde 2021-06-13 20:23:00 UTC
At least in my case the warning was valid, a failing disk controller had caused some CRC errors (most often those are caused just by a bad SATA cable, but may be a sign of hardware failure). And some other non-critical statistics were a bit high.
It still PASSES the SMART tests in smartctl as some amount of the CRC errors may be normal.

Double-check that there isn't anything suspicious in the SMART attributes, even if the overall status is Passed.

I'm not a developer but I don't think this specific translation error could have caused that; some bug could of course be elsewhere though.

Maybe file a new bug report to 'plasma-disks' (and include smartctl -x command output) if you think your HDD is okay and the error was for no reason; 
and a wishlist bug to 'kinfocenter' for the "more info" button.
Comment 6 Lasse Liehu 2021-06-13 22:15:43 UTC
As far as I understand, the application logic is the same, regardless of whether arguments are missing in the translation or not. Because the argument was missing, "(I18N_EXCESS_ARGUMENTS_SUPPLIED)" was shown instead of the detected list of instabilities.
Comment 7 Lasse Liehu 2021-06-13 22:27:33 UTC
(In reply to Ville Aakko from comment #4)
> The application should have a "more info" -button to show the output it
> thinks is the cause for these "early signs of malfunction".

Like mentioned above, the translation bug was that you don't see this detailed list. You could try and see if you can properly see it when using it in English. For example by typing in command line: LANG=en_US kcmshell5 smart

Otherwise this issue sounds like a new bug report.
Comment 8 Ville Aakko 2021-06-14 12:24:13 UTC
(In reply to Lasse Liehu from comment #7)

> Like mentioned above, the translation bug was that you don't see this
> detailed list. You could try and see if you can properly see it when using
> it in English. For example by typing in command line: LANG=en_US kcmshell5
> smart
> 
> Otherwise this issue sounds like a new bug report.

I agree (on all accounts). Thanks for all comments (despite being somewhat off-topic, sorry for that), in case I still get / find the behavior problematic, I'll open a new bug report (and will not discuss this any further here).

p.s. FWIW running with English or C locale, kinfocenter just points to "a log" (but not to I18N_EXCESS_ARGUMENTS_SUPPLIED anymore as expected). But it still does not point to a specific log or a specific error; I have no idea what it thinks is wrong, and why it thinks it is wrong. Grepping journal for sda, ata1 or wd80... (my hdd modeel) , everything seems to be just fine...