Bug 438175 - Vertical separator between columns in widescreen view differs in color from the separator between the sidebar and then KCM
Summary: Vertical separator between columns in widescreen view differs in color from t...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: 5.22.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 440550 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-06-06 18:19 UTC by Lua
Modified: 2024-02-02 16:39 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0


Attachments
Separators (3.57 KB, image/png)
2021-06-06 18:19 UTC, Lua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lua 2021-06-06 18:19:36 UTC
Created attachment 139040 [details]
Separators

SUMMARY


STEPS TO REPRODUCE
1. Open System Settings.

OBSERVED RESULT
The line next to the home icon and the one next to the "Colors" text have different shades of grey.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.2
Kernel Version: 5.4.0-73-generic (64-bit)
Graphics Platform: X11
Processors: 4 × Intel Core Processor (Skylake, IBRS)
Memory: 3.8 GiB of RAM
Graphics Processor: llvmpipe

ADDITIONAL INFORMATION
Comment 1 Lua 2021-06-06 18:20:39 UTC
 Also, there is an inconsistency with the text spacement. The "Colors" and "Appearance" have different spacements from the separators.
Comment 2 Nate Graham 2021-06-09 17:47:06 UTC
One issue per bug report please.
Comment 3 Nate Graham 2021-08-03 19:34:23 UTC
*** Bug 440550 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2023-01-27 20:55:23 UTC
https://invent.kde.org/frameworks/kirigami/-/merge_requests/903 changes this, but doesn't quiiiiite fix it.
Comment 5 Bug Janitor Service 2024-02-02 09:36:11 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1455
Comment 6 Bug Janitor Service 2024-02-02 11:23:35 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1457
Comment 7 Akseli Lahtinen 2024-02-02 11:25:58 UTC
Git commit 21de419ea73054589cf4ab90a8e0df5b24d8c546 by Akseli Lahtinen.
Committed on 02/02/2024 at 11:25.
Pushed by akselmo into branch 'master'.

Use header color instead of window for columnview separator

This makes the header separator colors match

| Before | After |
| ------ | ------ |
|    ![image](/uploads/817fe69ec3376d3ee49355653356c0c4/image.png)    |   ![image](/uploads/0ee2de1348ab0e3c1ec5d8a8142a8b5d/image.png)     |

M  +2    -2    src/columnview.cpp

https://invent.kde.org/frameworks/kirigami/-/commit/21de419ea73054589cf4ab90a8e0df5b24d8c546
Comment 8 Marco Martin 2024-02-02 11:30:03 UTC
Git commit a8e4348437df7edc4f07450dedffa8c34478a4dc by Marco Martin.
Committed on 02/02/2024 at 11:29.
Pushed by mart into branch 'master'.

Use Header color set on overlaydrawer

match colors on sidebar separators of Drawer as well

M  +2    -0    src/controls/OverlayDrawer.qml

https://invent.kde.org/frameworks/kirigami/-/commit/a8e4348437df7edc4f07450dedffa8c34478a4dc
Comment 9 Bug Janitor Service 2024-02-02 11:30:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/362
Comment 10 Bug Janitor Service 2024-02-02 11:33:34 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/291
Comment 11 Marco Martin 2024-02-02 11:41:44 UTC
Git commit e30109e950eb8b7062b64970ad3ac727dd9e1e57 by Marco Martin.
Committed on 02/02/2024 at 11:41.
Pushed by mart into branch 'master'.

Make sidebar drawer separators proper Separator

As everywhere else, use a Kirigami.Separator and since is a column
separator use the Header color set

M  +3    -0    org.kde.desktop/Drawer.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/e30109e950eb8b7062b64970ad3ac727dd9e1e57
Comment 12 Marco Martin 2024-02-02 12:26:53 UTC
Git commit a19d6c66195720683b148324f62ac9d29eb1ee52 by Marco Martin.
Committed on 02/02/2024 at 11:33.
Pushed by mart into branch 'master'.

Use Header color set for separators as with drawers and ColumnView

Make the color of the column separator consistent everywhere

M  +2    -0    app/sidebar/qml/Main.qml

https://invent.kde.org/plasma/systemsettings/-/commit/a19d6c66195720683b148324f62ac9d29eb1ee52
Comment 13 Marco Martin 2024-02-02 12:27:43 UTC
Git commit 18f3fc7d10b43788008486ae3d48704a147a537d by Marco Martin.
Committed on 02/02/2024 at 12:27.
Pushed by mart into branch 'Plasma/6.0'.

Use Header color set for separators as with drawers and ColumnView

Make the color of the column separator consistent everywhere

M  +2    -0    app/sidebar/qml/Main.qml

https://invent.kde.org/plasma/systemsettings/-/commit/18f3fc7d10b43788008486ae3d48704a147a537d