Bug 438137 - Implement KHamburgerMenu
Summary: Implement KHamburgerMenu
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
: 440351 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-06-05 23:01 UTC by Lua
Modified: 2021-11-09 03:26 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/okular/-/commit/e43cdc0d868c9c2068665af78358e8a30845e445
Version Fixed In: 21.12
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Lua 2021-06-05 23:01:12 UTC 
Other apps like Dolphin and Gwenview already moved to this design.
Comment 1 Laura David Hurka 2021-06-06 11:37:34 UTC 
Dolphin decided to hide the menu bar by default, but Okular has some useful actions there:

* Open...
* Save as...
* Print...
* Presentation

What other actions would need to be in the KHamburgerMenu? I think Dolphin had this question, and now they have put way to many actions in it.
Comment 2 Albert Astals Cid 2021-06-06 16:32:45 UTC 
I'm going to move this to wishlist from task, because that's your wish not a done deal.
Comment 3 Nate Graham 2021-06-09 17:31:16 UTC 
FWIW implementing KHamburgerMenu doesn't imply or require hiding the menu bar by default. The main bar can remain visible by default and then the hamburger menu only appears when the user has chosen to hide the menu bar. This is currently how Gwenview has it, in fact.

The design of what to put in the hamburger menu is of course a salient question. :) Personally I think this is quite doable:

- File menu: probably the hamburger menu will have many of these actions in it
- Edit menu: probably the hamburger menu will have most of these actions in it
- View, Go, and Tools menus: most of these are accessible through UI controls in the default toolbar and can therefore be omitted from the hamburger menu while they are still visible on the toolbar. Only a few will need to be visible in the hamburger menu by default.
- Bookmarks menu: ontents can be omitted from the hamburger menu if we add an "Add bookmark" button to the bookmarks panel in the sidebar

Seems quite doable. FWIW check out Dolphin's hamburger menu in git master. It's super streamlined and nice now.
Comment 4 Lua 2021-06-09 19:15:41 UTC 
> I'm going to move this to wishlist from task, because that's your wish not a done deal.

Sorry, I didn't understand. Is wrong to add "wishlist" when suggesting features?
Comment 5 Albert Astals Cid 2021-06-09 19:47:37 UTC 
It's not wrong to set wishlist, you set it to task, that is wrong.
Comment 6 Lua 2021-06-09 19:52:19 UTC 
Oops, I read too fast. Thanks for fixing it.
Comment 7 Nate Graham 2021-07-28 13:38:05 UTC 
*** Bug 440351 has been marked as a duplicate of this bug. ***
Comment 8 Albert Astals Cid 2021-08-02 20:51:52 UTC 
Please do not reset the default assignee.
Comment 9 Felix Ernst 2021-08-04 09:19:47 UTC 
Alright. I just wanted to make clear that I am working on this but this comment accomplishes this just as well. :)
Comment 10 Bug Janitor Service 2021-08-07 15:04:44 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/463
Comment 11 Nate Graham 2021-11-09 03:26:24 UTC 
Implemented by Felix Ernst with https://invent.kde.org/graphics/okular/-/commit/e43cdc0d868c9c2068665af78358e8a30845e445 in Okular 21.12!