Bug 438105 - some typos found in code
Summary: some typos found in code
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: translation (show other bugs)
Version: git (master)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-05 06:04 UTC by jack
Modified: 2021-10-06 06:07 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.1.2
Sentry Crash Report:


Attachments
attachment-20313-0.html (1.33 KB, text/html)
2021-09-10 14:49 UTC, jack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jack 2021-06-05 06:04:56 UTC
SUMMARY

----------------------------------------------------------------------

xmlstoragesettings.ui	posession 

<string>You can specify to encrypt the data also with the KMyMoney recover key. Only the core KMyMoney developers are in posession of the respective private key required to read back such encrypted data.&lt;p&gt;

"posession" should be "possession"

----------------------------------------------------------------------
kcm_checkprinting.desktop

Name[en_GB]=Configure the check printing plugin

"check" should be "cheque"


Keywords[en_GB]=checkprinting;kmymoney;

i assume "checkprinting" should be "chequeprinting"

----------------------------------------------------------------------
ktagsview_p.h
87:        m_updateAction = new QAction(Icons::get(Icon::DialogOK), i18nc("@action:button Update button in tags vew", "Update"), q);

"vew" should be "view"

----------------------------------------------------------------------
Comment 1 Thomas Baumgart 2021-06-05 09:32:57 UTC
Cool. 

ktagsview_p.h: The file has been removed (merged into ktagsview.cpp) lately and the spelling has been corrected (see https://invent.kde.org/office/kmymoney/-/blob/master/kmymoney/views/ktagsview.cpp#L92)

The spelling error in xmlstoragesettings.ui will be fixed soon. This spelling error is in there since at least Thu Nov 26 17:36:11 2009 +0000 and was ported over from SVN. I am impressed.

kcm_checkprinting.desktop: the translated desktop entries are maintained by the translation teams. Once I have fixed the above I will assign it to the en_GB team so that they can fix it.
Comment 2 Thomas Baumgart 2021-06-05 09:35:39 UTC
Git commit 81503655cba0cb5ad64a8111d288cdae685aa0dd by Thomas Baumgart.
Committed on 05/06/2021 at 09:35.
Pushed by tbaumgart into branch 'master'.

Fix spelling error
GUI:

M  +1    -1    kmymoney/plugins/xml/xmlstoragesettings.ui

https://invent.kde.org/office/kmymoney/commit/81503655cba0cb5ad64a8111d288cdae685aa0dd
Comment 3 Thomas Baumgart 2021-06-05 09:36:57 UTC
Git commit 5f191427452c6c45a601c37bdd8e4ec76d495ef0 by Thomas Baumgart.
Committed on 05/06/2021 at 09:36.
Pushed by tbaumgart into branch '5.1'.

Fix spelling error
GUI:
(cherry picked from commit 81503655cba0cb5ad64a8111d288cdae685aa0dd)

M  +1    -1    kmymoney/plugins/xml/xmlstoragesettings.ui

https://invent.kde.org/office/kmymoney/commit/5f191427452c6c45a601c37bdd8e4ec76d495ef0
Comment 4 Jack 2021-06-07 02:07:36 UTC
Sorry if I've lost track of what has or has not been fixed, but check is correct for US English, and (I assume) cheque is correct for UK English.  Is there a clear statement of which the base code should be using?
Comment 5 jack 2021-06-07 05:13:26 UTC
i merely submitted the bug, so i know nothing.

but i can confirm that 'cheque' is the word to use in UK English. 

if something has '[en_GB]' in front of it, i reckon it should be in UK English. 

i *assume* (always a poor thing to do) that the base code uses US English.
Comment 6 Thomas Baumgart 2021-06-07 07:47:41 UTC
I am not aware of any clear statement of which regional version of English the base code should be using. It must be consistent though. In case of KMyMoney it is the US version and the UK version is a translation and thus handled by the i18n team.

I have sent a mail to https://l10n.kde.org/team-infos.php?teamcode=en_GB but it seems to be sitting in moderation. Not sure.
Comment 7 Steve Allewell 2021-09-10 13:46:37 UTC
My apologies for not seeing this issue sooner.

I will update the kcm_checkprinting.desktop text today.  Regarding the keywords, I have never been a fan of these run together words, would this be better if it was changed to "check;printing;kymymoney;" in the base code and I would translate to "cheque;printing;kmymoney".

Regards
Comment 8 jack 2021-09-10 14:49:43 UTC
Created attachment 141441 [details]
attachment-20313-0.html

It would indeed be better to chop up the compound words as you suggest.

Thanks

⁣Jack​

On 10 Sep 2021, 14:46, at 14:46, Steve Allewell <bugzilla_noreply@kde.org> wrote:
>https://bugs.kde.org/show_bug.cgi?id=438105
>
>Steve Allewell <steve.allewell@gmail.com> changed:
>
>           What    |Removed                     |Added
>----------------------------------------------------------------------------
>               CC|                            |steve.allewell@gmail.com
>
>--- Comment #7 from Steve Allewell <steve.allewell@gmail.com> ---
>My apologies for not seeing this issue sooner.
>
>I will update the kcm_checkprinting.desktop text today.  Regarding the
>keywords, I have never been a fan of these run together words, would
>this be
>better if it was changed to "check;printing;kymymoney;" in the base
>code and I
>would translate to "cheque;printing;kmymoney".
>
>Regards
>
>--
>You are receiving this mail because:
>You reported the bug.
Comment 9 Thomas Baumgart 2021-09-10 18:39:33 UTC
In general I agree. The question is, where these keywords are used and what the meaning of 'check' in another context without a reference to printing may mean.
Comment 10 jack 2021-09-11 05:54:26 UTC
i can't help there... it's a problem.

fwiw, i can give you one of my mail sigs that illustrates this very
problem. i took it from from some microsoft spec years ago... i removed
some words in the middle, but this is the essence of what the sentence said:



     "...check the database property...to ensure that it is not checked"



jack
the fast gorilla skied over a lazy cloud



On 10/09/2021 19:39, Thomas Baumgart wrote:
> https://bugs.kde.org/show_bug.cgi?id=438105
>
> --- Comment #9 from Thomas Baumgart <tbaumgart@kde.org> ---
> In general I agree. The question is, where these keywords are used and what the
> meaning of 'check' in another context without a reference to printing may mean.
>
Comment 11 Steve Allewell 2021-09-11 11:35:28 UTC
I'm not sure who would search for checkprinting or chequeprinting as a single word.  I'm not sure how the keyword search works, but perhaps it should be possible to use "check AND printing" to return only things that have both.

Out of interest, I do have kmymoney installed, and searching for checkprinting doesn't actually show it up.  I've checked the kcm_checkprinting.desktop file and it does have that keyword.  There is always the possibility my search is broken.  I'll check into that.

Regards
Comment 12 Thomas Baumgart 2021-09-11 16:03:22 UTC
Seems to be fixed: https://invent.kde.org/office/kmymoney/-/commit/0af86e0
Comment 13 Thomas Baumgart 2021-10-06 06:07:13 UTC
Updated ticket status reflecting current source code status