Bug 438020 - Only one K3b theme is available in Discover
Summary: Only one K3b theme is available in Discover
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: KNewStuff Backend (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-03 01:33 UTC by Patrick Silva
Modified: 2021-10-20 13:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (89.47 KB, image/png)
2021-06-03 01:33 UTC, Patrick Silva
Details
k3b themes (482.13 KB, image/png)
2021-09-27 15:39 UTC, Aleix Pol
Details
Video when it works (400.68 KB, video/mp4)
2021-09-28 22:43 UTC, Aleix Pol
Details
full debug (91.97 KB, text/plain)
2021-09-29 16:13 UTC, Patrick Silva
Details
debug log when Discover finds no K3b thene (57.89 KB, text/x-log)
2021-09-29 16:38 UTC, Patrick Silva
Details
screenshot - no K3b theme found (62.68 KB, image/png)
2021-09-29 16:41 UTC, Patrick Silva
Details
output after attica MR (58.94 KB, text/x-log)
2021-09-30 01:47 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-06-03 01:33:33 UTC
Created attachment 138967 [details]
screenshot

STEPS TO REPRODUCE
1. open Discover
2. click on "Applications addons" in the sidebar
3. click on "K3b Themes" in the sidebar 

OBSERVED RESULT
Currently, 26 K3b themes are available on https://store.kde.org/browse/cat/180/order/latest/
However, Alliance is the only K3b theme available in Discover.
Please see the attached screenshot.

EXPECTED RESULT
all K3b themes listed in Discover

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.3
Graphics Platform: Wayland
Comment 1 Aleix Pol 2021-09-27 15:39:50 UTC
Created attachment 141954 [details]
k3b themes

Cannot reproduce
Comment 2 Aleix Pol 2021-09-27 15:40:09 UTC
Please
Comment 3 Aleix Pol 2021-09-27 15:40:23 UTC
Please provide some more information as to what you are seeing
Comment 4 Patrick Silva 2021-09-27 18:08:01 UTC
I see the same thing seen in my screenshot already attached.
However, I have noticed that the bug only occurs in my main user account.
The only output I see in Konsole after click on "K3b Themes" in the sidebar is

org.kde.plasma.libdiscover: last stream isn't over yet Filters(category: Category(0x55bfd36c0320, name = "K3B Themes"),) ResourcesProxyModel(0x55bfd69ac8b0)

I have just uninstalled the only theme that was installed, called Alliance, restarted Discover and now Discover lists all K3b themes in my main user account too. The bug occurs again if I install Alliance theme and restart Discover.

Apparently the bug here is that Discover only lists installed K3b themes.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.3
Graphics Platform: Wayland
Comment 5 Patrick Silva 2021-09-27 18:41:23 UTC
(In reply to Patrick Silva from comment #4)
> Apparently the bug here is that Discover only lists installed K3b themes.

Same thing with other apps addons. I onle see installed addons of these categories:

Kmail header theme
Krunner
PagesSysten monitor Sensor Display Styles
Yakuake
Comment 6 Patrick Silva 2021-09-27 19:36:05 UTC
Pages category of app addons is also affected.

These categories of Plasma addons are affected:
Wallpapers
Wallpaper plugins
Window Manager Effects
Window Manager Scripts
Window Manager Switching Layouts


These categories of Plasma addons are intermittently affected:
Cursors
Icons
Global Themes
Plasma Styles
Comment 7 Aleix Pol 2021-09-28 17:27:33 UTC
Would someone be able to test if this MR solves these problems?

https://invent.kde.org/plasma/discover/-/merge_requests/169
Comment 8 Aleix Pol 2021-09-28 17:27:59 UTC
And by someone I mean you, Patrick, ^^'
Comment 9 Patrick Silva 2021-09-28 19:24:34 UTC
(In reply to Aleix Pol from comment #7)
> Would someone be able to test if this MR solves these problems?
> 
> https://invent.kde.org/plasma/discover/-/merge_requests/169

Same thing after your patch.
Comment 10 Aleix Pol 2021-09-28 22:36:27 UTC
I'm going to guess the issue is on Categories that have >20 items (which is the page size we have right now, if there's more we get to request them after).

Would you be able to give us the output of Discover running with "knewstuff (Core Lib)" Full Debug enabled?

Also could you make sure you're patient enough when it's fetching? I've seen it take quite a bit of time sometimes... (not more than 1 minute, although it might depend)
Comment 11 Aleix Pol 2021-09-28 22:43:05 UTC
Created attachment 142000 [details]
Video when it works

This is what I see, for reference
Comment 12 Aleix Pol 2021-09-28 22:44:00 UTC
I have an idea of what could be wrong. Do you have installed assets for all of the categories that don't work?
Comment 13 Patrick Silva 2021-09-28 23:06:24 UTC
I wait until "Still looking" disappears.
In the case of intermittently affected categories, their addons are listed
as expected after selecting another category and then switching back.

Other categories are consistently affected if any of their addons is installed.
By "asset" do you mean "addon"?

I need instructions to run Discover with "knewstuff (Core Lib)" Full Debug enabled.
Comment 14 Aleix Pol 2021-09-29 15:13:26 UTC
Yes, by asset I meant addon.

> I need instructions to run Discover with "knewstuff (Core Lib)" Full Debug enabled.

Open "kdebugsettings" (apt install kdebugsettings) and filter for knewstuff, you need to change it on the combo box by "KNewStuff (Core Lib)". Then you need to restart Discover.
Comment 15 Patrick Silva 2021-09-29 16:13:12 UTC
Created attachment 142007 [details]
full debug

(In reply to Aleix Pol from comment #12)
> Do you have installed assets for all of the categories that don't work?

yes


The output of Discover running with "knewstuff (Core Lib)" Full Debug enabled
is attached.
Comment 16 Patrick Silva 2021-09-29 16:38:13 UTC
Created attachment 142008 [details]
debug log when Discover finds no K3b thene

The problem with K3b themes is intermitent now.
If a K3b theme is installed, sometimes Discover lists all themes available
as expcted, sometimes it says "Nothing found". I'm attaching the full output gotten when Discover found no K3b theme.
Comment 17 Patrick Silva 2021-09-29 16:41:49 UTC
Created attachment 142009 [details]
screenshot - no K3b theme found
Comment 18 Aleix Pol 2021-09-30 00:14:41 UTC
Created the following MR in attica to address this. In the logs I noticed you have:

KNS error in "K3B Themes" : KNSCore::NetworkError "Network error 5: Operation canceled" QVariant(int, 5)
invalid kns backend! "/usr/share/knsrcfiles/k3btheme.knsrc" because: "Network error in backend K3B Themes: 5"

Which happens specifically for K3B. It's because when going into the deeper category the original job gets aborted. This is reported by KNS as a network error and then Discover marks the backend as invalid.

@Patrick, would you be able to test the patch maybe? I haven't been able to reproduce the problem, even though it makes a lot of sense.
Comment 19 Patrick Silva 2021-09-30 01:28:04 UTC
I have applied your MR to neon unstable

https://invent.kde.org/frameworks/attica/-/merge_requests/16

Discover says "Nothing found" for K3b themes, kwin effects and kwin scripts.

Discover only lists non-installed addons under certain categories (Global themes,
Icons, gtk themes, servicemenu) and lists all addons under other categories.
Comment 20 Aleix Pol 2021-09-30 01:34:26 UTC
Can you check if you still have the output of
KNS error in "K3B Themes" : KNSCore::NetworkError "Network error 5: Operation canceled" QVariant(int, 5)?
Or actually, can you just send us again the output?

I'll go ahead and get the Discover MR merged already anyway, I'm sure it fixes things.
Comment 21 Patrick Silva 2021-09-30 01:47:00 UTC
Created attachment 142021 [details]
output after attica MR

yes, I see the same network error. Output attached again.
Comment 22 Aleix Pol 2021-09-30 11:01:15 UTC
This doesn't make sense, I'm not sure this is running the patched Attica. I'm going to merge the MR and hopefully it will all be fixed. Please reopen otherwise.
Comment 23 Patrick Silva 2021-10-01 16:14:07 UTC
(In reply to Aleix Pol from comment #22)
> This doesn't make sense, I'm not sure this is running the patched Attica.

My steps to apply your MR:

1. $git clone https://invent.kde.org/frameworks/attica.git
2. downloaded the plain diff of your MR to attica folder created after
the step 1
3. $cd attica
4. $git apply <plain diff of your MR>
5. $mkdir build && cd build
6. $cmake ..
7. $make
8. $sudo make install

If I did something wrong, please tell me.
Comment 24 Aleix Pol 2021-10-04 01:34:25 UTC
can you check where it's getting installed? 

See install_manifest.txt
Comment 25 Patrick Silva 2021-10-04 02:12:39 UTC
contents of install_manifest.txt:

/usr/include/KF5/Attica/Attica/Activity
/usr/include/KF5/Attica/Attica/AccountBalance
/usr/include/KF5/Attica/Attica/Achievement
/usr/include/KF5/Attica/Attica/Comment
/usr/include/KF5/Attica/Attica/Config
/usr/include/KF5/Attica/Attica/Content
/usr/include/KF5/Attica/Attica/Category
/usr/include/KF5/Attica/Attica/DeleteJob
/usr/include/KF5/Attica/Attica/Distribution
/usr/include/KF5/Attica/Attica/DownloadDescription
/usr/include/KF5/Attica/Attica/DownloadItem
/usr/include/KF5/Attica/Attica/Event
/usr/include/KF5/Attica/Attica/Folder
/usr/include/KF5/Attica/Attica/Forum
/usr/include/KF5/Attica/Attica/GetJob
/usr/include/KF5/Attica/Attica/HomePageEntry
/usr/include/KF5/Attica/Attica/HomePageType
/usr/include/KF5/Attica/Attica/Icon
/usr/include/KF5/Attica/Attica/ItemJob
/usr/include/KF5/Attica/Attica/KnowledgeBaseEntry
/usr/include/KF5/Attica/Attica/ListJob
/usr/include/KF5/Attica/Attica/License
/usr/include/KF5/Attica/Attica/Message
/usr/include/KF5/Attica/Attica/Metadata
/usr/include/KF5/Attica/Attica/Person
/usr/include/KF5/Attica/Attica/PrivateData
/usr/include/KF5/Attica/Attica/PostJob
/usr/include/KF5/Attica/Attica/Project
/usr/include/KF5/Attica/Attica/PutJob
/usr/include/KF5/Attica/Attica/RemoteAccount
/usr/include/KF5/Attica/Attica/BuildService
/usr/include/KF5/Attica/Attica/BuildServiceJob
/usr/include/KF5/Attica/Attica/BuildServiceJobOutput
/usr/include/KF5/Attica/Attica/ProviderManager
/usr/include/KF5/Attica/Attica/Provider
/usr/include/KF5/Attica/Attica/Publisher
/usr/include/KF5/Attica/Attica/PublisherField
/usr/include/KF5/Attica/Attica/Topic
/usr/lib/x86_64-linux-gnu/libKF5Attica.so.5.87.0
/usr/lib/x86_64-linux-gnu/libKF5Attica.so.5
/usr/lib/x86_64-linux-gnu/libKF5Attica.so
/usr/include/KF5/Attica/attica/activity.h
/usr/include/KF5/Attica/attica/accountbalance.h
/usr/include/KF5/Attica/attica/achievement.h
/usr/include/KF5/Attica/attica/comment.h
/usr/include/KF5/Attica/attica/config.h
/usr/include/KF5/Attica/attica/content.h
/usr/include/KF5/Attica/attica/category.h
/usr/include/KF5/Attica/attica/deletejob.h
/usr/include/KF5/Attica/attica/distribution.h
/usr/include/KF5/Attica/attica/downloaddescription.h
/usr/include/KF5/Attica/attica/downloaditem.h
/usr/include/KF5/Attica/attica/event.h
/usr/include/KF5/Attica/attica/folder.h
/usr/include/KF5/Attica/attica/forum.h
/usr/include/KF5/Attica/attica/getjob.h
/usr/include/KF5/Attica/attica/homepageentry.h
/usr/include/KF5/Attica/attica/homepagetype.h
/usr/include/KF5/Attica/attica/icon.h
/usr/include/KF5/Attica/attica/itemjob.h
/usr/include/KF5/Attica/attica/knowledgebaseentry.h
/usr/include/KF5/Attica/attica/listjob.h
/usr/include/KF5/Attica/attica/license.h
/usr/include/KF5/Attica/attica/message.h
/usr/include/KF5/Attica/attica/metadata.h
/usr/include/KF5/Attica/attica/person.h
/usr/include/KF5/Attica/attica/privatedata.h
/usr/include/KF5/Attica/attica/postjob.h
/usr/include/KF5/Attica/attica/project.h
/usr/include/KF5/Attica/attica/putjob.h
/usr/include/KF5/Attica/attica/remoteaccount.h
/usr/include/KF5/Attica/attica/buildservice.h
/usr/include/KF5/Attica/attica/buildservicejob.h
/usr/include/KF5/Attica/attica/buildservicejoboutput.h
/usr/include/KF5/Attica/attica/providermanager.h
/usr/include/KF5/Attica/attica/provider.h
/usr/include/KF5/Attica/attica/publisher.h
/usr/include/KF5/Attica/attica/publisherfield.h
/usr/include/KF5/Attica/attica/topic.h
/usr/include/KF5/Attica/attica/atticabasejob.h
/usr/include/KF5/Attica/attica/atticautils.h
/usr/include/KF5/Attica/attica/platformdependent.h
/usr/include/KF5/Attica/attica/platformdependent_v2.h
/usr/include/KF5/Attica/attica/version.h
/usr/include/KF5/Attica/attica/attica_export.h
/usr/share/qlogging-categories5/attica.categories
/usr/share/qlogging-categories5/attica.renamecategories
/usr/lib/x86_64-linux-gnu/qt5/mkspecs/modules/qt_Attica.pri
/usr/lib/x86_64-linux-gnu/pkgconfig/libKF5Attica.pc
/usr/lib/x86_64-linux-gnu/cmake/KF5Attica/KF5AtticaConfig.cmake
/usr/lib/x86_64-linux-gnu/cmake/KF5Attica/KF5AtticaConfigVersion.cmake
/usr/lib/x86_64-linux-gnu/cmake/KF5Attica/KF5AtticaTargets.cmake
/usr/lib/x86_64-linux-gnu/cmake/KF5Attica/KF5AtticaTargets-debug.cmake
/usr/include/KF5/attica_version.h
Comment 26 Patrick Silva 2021-10-20 13:09:34 UTC
I'm unable to reproduce on Arch (Plasma 5.23.1) and neon unstable.