Bug 437979 - Switching global themes and choosing to use desktop layout duplicates application launcher keyboard shortcut, unbinding meta key
Summary: Switching global themes and choosing to use desktop layout duplicates applica...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_lookandfeel (show other bugs)
Version: 5.21.5
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-02 02:31 UTC by Unknown
Modified: 2022-08-04 17:29 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26
Sentry Crash Report:


Attachments
Two Application Launcher shortcut entries, both nonfunctional (44.52 KB, image/png)
2021-06-02 02:31 UTC, Unknown
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2021-06-02 02:31:00 UTC
Created attachment 138935 [details]
Two Application Launcher shortcut entries, both nonfunctional

SUMMARY
Choosing to switch the global theme and selecting the checkbox to apply the associated desktop layout duplicates the "Activate Application Launcher" shortcut under the "Plasma" category. One of the duplicates has the default Alt F1 set for the meta key to function but the other is blank. This results in an unusable meta regardless of which one is set to Alt F1.

STEPS TO REPRODUCE
1. Select any theme in Global Themes in System Settings
2. Choose to apply the desktop layout with the checkbox
3. Attempt to activate application launcher with meta key

OBSERVED RESULT
Application Launcher does not respond to meta key as the keyboard shortcut is now duplicated with no easy way to remove one

EXPECTED RESULT
Only one Application Launcher shortcut entry is present at any time under keyboard shortcuts. It either stays bound to alt f1 or is unbound (if the creator of the theme really intended to) with a way to rebind it.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch - fully up to date as of 6/1/21, clean install for testing
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
This issue was also present on Fedora KDE. The default key bindings also have no meta key functionality yet KDE comes with this out of the box. This should probably be remedied as well.
Comment 1 Nate Graham 2021-06-08 22:35:55 UTC
I wonder if this could be one of the causes of Bug 391322.
Comment 2 Bug Janitor Service 2022-07-20 13:43:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1937
Comment 3 Nate Graham 2022-08-04 16:41:13 UTC
Git commit 40d6e18b0f153464a64b3e21c1224e13511632d2 by Nate Graham, on behalf of David Redondo.
Committed on 04/08/2022 at 16:23.
Pushed by ngraham into branch 'master'.

Take active screen in account and remove shortcut requirement for activating launcher

With the information about the active screen we can make an educated
guess about where the attention of the user is and where they could
expect the launcher to open. If on the screen no launcher could be
activated, look at all launchers. Also remove the requirement for
launchers to have a shortcut. This is needed to make this feature
work reliably and should reduce the instances of "Meta key stopped working"
happening in general.
Related: bug 391322, bug 444343, bug 447962

M  +29   -9    shell/shellcorona.cpp
M  +1    -0    shell/shellcorona.h

https://invent.kde.org/plasma/plasma-workspace/commit/40d6e18b0f153464a64b3e21c1224e13511632d2