Bug 437870 - Visual Consistency: Some KCMs Have Different Lines
Summary: Visual Consistency: Some KCMs Have Different Lines
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_touchpad (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-30 17:45 UTC by Andres Betts
Modified: 2021-10-29 04:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.24
Sentry Crash Report:


Attachments
separatorline1 (145.02 KB, image/png)
2021-05-30 17:45 UTC, Andres Betts
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2021-05-30 17:45:16 UTC
Created attachment 138885 [details]
separatorline1

Just noticed that the kuserfeedback shows a separation line when the content reaches a certain scrolling position while others do not show any separator line. Examples provided. I think we want to find consistency and give all of them a separator line when scrolling.
Comment 1 Nate Graham 2021-06-08 22:12:00 UTC
This is because the Touchpad KCM is written as a Kirigami.ScrollablePage rather than a KCM.[whatever]. It needs to be ported.
Comment 2 Andres Betts 2021-06-09 01:31:56 UTC
I kind had a thought about that, good to know.
Comment 3 Nate Graham 2021-10-29 04:53:28 UTC
Git commit cb99f328d76a61fe9fa4c52387ac1310e0b9da80 by Nate Graham.
Committed on 29/10/2021 at 04:52.
Pushed by ngraham into branch 'master'.

kcms/touchpad: Hide device combobox when there is only one touchpad

The HIG says this is fine because it's a hardware condition.
FIXED-IN: 5.24

M  +1    -1    kcms/touchpad/kcm/libinput/touchpad.qml

https://invent.kde.org/plasma/plasma-desktop/commit/cb99f328d76a61fe9fa4c52387ac1310e0b9da80