Bug 437807 - import audio file metadata
Summary: import audio file metadata
Status: RESOLVED DUPLICATE of bug 429803
Alias: None
Product: tellico
Classification: Applications
Component: general (show other bugs)
Version: 3.3.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-29 00:16 UTC by mark
Modified: 2021-06-15 01:19 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mark 2021-05-29 00:16:36 UTC
SUMMARY
I haven't attempted this in a year but last time i used it there were no issues.  Now when i go to import audio file metadata, after clicking ok to start it returned back to the main screen and doesn't do anything.  I've tried running it from the command line to get error message and nothing. So is this a bug introduced since the last time i tried an import or something else.  there should be a better way to get errors messages out of this product.

STEPS TO REPRODUCE
1. file > Import > import audio file metadata
2. select directory with audio files
3. select import options click import

OBSERVED RESULT
nothing happens. no error messages

EXPECTED RESULT
import the metadata of my 15,000 audio files

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: fedora 33 
(available in About System)
KDE Plasma Version: 5.20.5
KDE Frameworks Version: KDE Frameworks 5.79.0
Qt Version: Qt 5.15.2 (built against 5.15.2)

ADDITIONAL INFORMATION
if this is not a bug i need a way to debug and get error and other info messages out of telliloc
Comment 1 Robby Stephenson 2021-05-31 01:12:40 UTC
Is your version compiled with debug support?

What previous version worked?

What type of audio files do you have?

Have you updated or removed taglib since the last time Tellico worked successfully for you?
Comment 2 mark 2021-06-05 16:02:12 UTC
> Is your version compiled with debug support?
My version is installed via the Fedora repository, it does not seem to be.
tellico-3.3.4-1.fc33.x86_64

> What previous version worked?
I don't know what the last version was that worked.  from the data on the .tc file i last scanned my audio files March 2020.

> What type of audio files do you have?
I have flac files which were never a problem before

> Have you updated or removed taglib since the last time Tellico worked successfully for you?taglib is installed.
taglib-1.12-4.fc33.x86_64

i can contact the fedora package maintainer and request they make available a debug version if there isn't some hidden switch or undocumented option to aid in debugging.
Comment 3 Robby Stephenson 2021-06-08 01:28:56 UTC
(In reply to mark from comment #2)
> > Is your version compiled with debug support?
> My version is installed via the Fedora repository, it does not seem to be.
> tellico-3.3.4-1.fc33.x86_64
> 
> > What previous version worked?
> I don't know what the last version was that worked.  from the data on the
> .tc file i last scanned my audio files March 2020.
> 
> > What type of audio files do you have?
> I have flac files which were never a problem before

Thanks. My test FLAC files seem to work as expected when importing the metadata. Tellico did have some fixes for version 3.3.5 related to audio files, https://bugs.kde.org/show_bug.cgi?id=429803, and it will skip any file which does not have an album name included in the metadata (since albums are the items Tellico tracks).

> i can contact the fedora package maintainer and request they make available
> a debug version if there isn't some hidden switch or undocumented option to
> aid in debugging.

As you've seen, without debugging being enabled, all of the diagnostic or logging output is suppressed. Tellico doesn't have an internal log file or anything like that.

I know FLAC files are typically fairly large so trying to share a test file would be problematic. taglib usually comes with a command line tool called tagreader which will dump all the tags from a file - could you paste the output from tagreader for one of the flac files which doesn't import? I could look that over, maybe create a test file with the same metadata and see if I could recreate the issue.
Comment 4 mark 2021-06-08 18:43:20 UTC
I have thought of a possible change since the last time i scanned all my media with tellico.  I used "MusicBrainz Picard" to get the tags closer to something standardized. Before there might be about 10 tags set, now it sets 30+ tags.
Here is an example from a MediaInfo dump:
General
Complete name                            : /music/music library/Pop/ABBA/Gold - Greatest Hits/01 - Dancing Queen.flac
Format                                   : FLAC
Format/Info                              : Free Lossless Audio Codec
File size                                : 27.2 MiB
Duration                                 : 3 min 52 s
Overall bit rate mode                    : Variable
Overall bit rate                         : 981 kb/s
Album                                    : Gold: Greatest Hits
Part                                     : 1
Part/Total                               : 1
Track name                               : Dancing Queen
Track name/Position                      : 1
Track name/Total                         : 19
Performer                                : Rutger Gunnarsson (bass);Roger Palm (drums (drum set))
Composer                                 : ABBA
Label                                    : Polydor
Genre                                    : Pop
Recorded date                            : 2010-12-07
ISRC                                     : SEAYD7601020 / SEUV71000390 / USAT20302166 / USAT20903514
Cover                                    : Yes
Cover type                               : Cover (front)
Cover MIME                               : image/jpeg
Comment                                  : fre:ac
MUSICBRAINZ_RELEASEGROUPID               : b69d665a-3eee-39f3-b156-58b122232304
ORIGINALDATE                             : 1992-09-21
ORIGINALYEAR                             : 1992
RELEASETYPE                              : album / compilation
ASIN                                     : B0046K1FZY
SCRIPT                                   : Latn
RELEASESTATUS                            : official
BARCODE                                  : 602527522593
RELEASECOUNTRY                           : US
ALBUMARTISTSORT                          : ABBA
MEDIA                                    : CD
ARRANGER                                 : Benny Andersson / Björn Ulvaeus
ENGINEER                                 : Michael B. Tretow
PRODUCER                                 : Benny Andersson / Björn Ulvaeus
WRITER                                   : Stig Anderson / Benny Andersson / Björn Ulvaeus
ARTISTSORT                               : ABBA
ARTISTS                                  : ABBA
MUSICBRAINZ_RELEASETRACKID               : d0656369-3c2b-397c-9020-fc1653fa517c
Album/Composer                           : ABBA

Audio
Format                                   : FLAC
Format/Info                              : Free Lossless Audio Codec
Duration                                 : 3 min 52 s
Bit rate mode                            : Variable
Bit rate                                 : 978 kb/s
Channel(s)                               : 2 channels
Channel layout                           : L R
Sampling rate                            : 44.1 kHz
Bit depth                                : 16 bits
Compression mode                         : Lossless
Stream size                              : 27.1 MiB (100%)
Writing library                          : libFLAC 1.2.1 (UTC 2007-09-17)
Language                                 : English
Comment 5 mark 2021-06-11 22:23:40 UTC
I managed to build the debug version of tellico on my system from the RPM src package.  I'm still not getting any info what the program is doing.  it immediately returns after i give it the directory i want scanned and doesn't scan.   I can't even tell if it attempted to open a file.

i did build it with this option:
cmake ..   -DCMAKE_BUILD_TYPE=debug  -DCMAKE_INSTALL_PREFIX=`kf5-config --prefix`

$ ./tellico
qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 4685, resource id:14682246, major code: 40 (TranslateCoords), minor code: 0
qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 6740, resource id:14682255, major code: 40 (TranslateCoords), minor code: 0
Comment 6 Robby Stephenson 2021-06-12 23:25:31 UTC
Sorry to ask a basic question, but confirm you've got "Recursive folder search" checked in the import options? I just discovered  that that checkbox has a bug in some aspects where the check is not respected, but I did want to ask
Comment 7 mark 2021-06-13 01:13:25 UTC
I did have the "recursive folder search" checked.  I've even tried checking, unchecking, checking and still nothing happens.
Comment 8 Robby Stephenson 2021-06-13 16:05:54 UTC
(In reply to mark from comment #5)
> I managed to build the debug version of tellico on my system from the RPM
> src package.  I'm still not getting any info what the program is doing.  it
> immediately returns after i give it the directory i want scanned and doesn't
> scan.   I can't even tell if it attempted to open a file.

The lack of anything on the command line for debug output combined with nothing being imported implies it's not even reading the directory to consider the files. I'll keep poking at it.
Comment 9 mark 2021-06-13 21:19:29 UTC
what is your "debug" suppose to dump out? I would have expected it to state when it enter/leaves modules.   I finally ran strace on it and i can see where it does open the directory when i select it and it sees there are 14 entries in the directory.  It doesn't matter if recursive is select or now as i'm only selecting an individual album directory so there is nothing in it but flac files.  I do not see where it opened any of the flac files from the strace.  I don't see any unusual errors.   It just returns without doing any scans of the individual files.
Comment 10 Robby Stephenson 2021-06-14 00:50:42 UTC
(In reply to mark from comment #9)
> what is your "debug" suppose to dump out? I would have expected it to state
> when it enter/leaves modules.   I finally ran strace on it and i can see
> where it does open the directory when i select it and it sees there are 14
> entries in the directory.  It doesn't matter if recursive is select or now
> as i'm only selecting an individual album directory so there is nothing in
> it but flac files.  I do not see where it opened any of the flac files from
> the strace.  I don't see any unusual errors.   It just returns without doing
> any scans of the individual files.

Yeah, I think we've established the existing diagnostic output doesn't meet your expectations. :) It's concentrated on the scenario where an audio file is read and considered but then doesn't get added to the collection for whatever reason (no album, no track number, inconsistent artist, bad merging of entries, etc.).

So like I said, the lack of any output seems to indicate that the directory may be read for the list of files but something is keeping those files from either being scanned or read. That part of the code hasn't changed much in a while, so I'm also at a bit of a loss why it might have worked before but not now. So I'm going back through any recent changes again. Nothing in my unit tests are showing up as having any problems.
Comment 11 Robby Stephenson 2021-06-15 01:19:41 UTC
(In reply to mark from comment #2)
> > Is your version compiled with debug support?
> My version is installed via the Fedora repository, it does not seem to be.
> tellico-3.3.4-1.fc33.x86_64

I should have caught this initially. I'm 99% sure that you've hit bug 429803 which was fixed in Tellico 3.3.5.

Once you're able to try a more recent version (3.3.5 or 3.4.1), please let me know if the issue has been corrected. I'm going to go ahead and mark this as a duplicate but certainly re-open it if that turns out not to be the case.

*** This bug has been marked as a duplicate of bug 429803 ***