Bug 437759 - Safe Assert Failure in KisAsyncAnimRendererBase: (m_d->requestedFrame == frame)
Summary: Safe Assert Failure in KisAsyncAnimRendererBase: (m_d->requestedFrame == frame)
Status: RESOLVED WORKSFORME
Alias: None
Product: krita
Classification: Applications
Component: Animation (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Other Linux
: NOR crash
Target Milestone: ---
Assignee: Eoin O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-28 00:57 UTC by Eoin O'Neill
Modified: 2021-07-09 04:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eoin O'Neill 2021-05-28 00:57:01 UTC
SUMMARY
There's a safe assert here (KisAsyncAnimationRendererBase::line 116) that's failing, and it's unclear why it's failing. I'll need to debug why this is happening more next week.

STEPS TO REPRODUCE
1. UNSURE, happens very rarely, sometimes during operations such as `Insert Hold Frames`

QUESTIONS:
1) There was a switch away from using Safe asserts for some parts of the code, and the question is whether or not this failure is supposed to "crash" the user, or if we really just want to early return. It seems to me that in the case where a thread might lose out on rendering to another thread, we should just early return and ignore the late frame and move on to the next one.

2) If the answer to 1 is that a crash is intended, there are a few different places where the AsyncAnimRendererBase is used -- we need to figure out exactly which child class is causing this exception to throw. (My assumption would be the Storyboard Docker's custom implementation...)

SOFTWARE/OS VERSIONS
 Krita git-hash: 56d09e2386fc6e793455be906d7a6bdb44d4f3fc
 OS: Manjaro 21.0.4 Ornara
 Kernel: x86_64 Linux 5.10.38-1-MANJARO
 Shell: bash 5.1.8
 Resolution: 3120x1920
 WM: sway
 Disk: 1.2T / 3.8T (32%)
 CPU: Intel Core i7-4770K @ 8x 3.9GHz [40.0°C]
 GPU: Radeon RX 590 Series (POLARIS10, DRM 3.40.0, 5.10.38-1-MANJARO, LLVM 11.1.0)
 RAM: 5063MiB / 11916MiB
Comment 1 Eoin O'Neill 2021-06-09 02:35:29 UTC
Hmm, as an update -- I can't seem to reproduce this bug after a week of trying w/ GDB.

It might have been an issue since resolved in master. It happened around the time of the MacOS related cmake changes, and I haven't seen it happen since.

I'll keep this on NEEDSINFO and continue to run krita w/ GDB until I can intentionally reproduce it.
Comment 2 Bug Janitor Service 2021-06-24 04:33:45 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2021-07-09 04:33:44 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!