Bug 437736 - digiKam 7.3 doesn't have a Translators tab in its About dialogue anymore
Summary: digiKam 7.3 doesn't have a Translators tab in its About dialogue anymore
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-i18n (show other bugs)
Version: 7.3.0
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-27 12:38 UTC by Tyson Tan
Modified: 2021-06-05 11:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.3.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2021-05-27 12:38:20 UTC
digiKam 7.3 (digiKam-7.3.0-20210526T190934-Win64) does't have a Translators tab in its About dialogue anymore. digiKam 7.2.0 had it.

Since Elisa and Marble also have the same issue recently, it could be KDE Framework's About dialogue module's fault?
Comment 1 caulier.gilles 2021-05-27 13:25:57 UTC
Hi,

Yes, it's a framework issue, as digiKam use KF5 for this kind of feature

Gilles Caulier
Comment 2 Tyson Tan 2021-05-27 13:34:58 UTC
Thanks. I have reported it to kxmlgui as well:
https://bugs.kde.org/show_bug.cgi?id=437738
Comment 3 Tyson Tan 2021-06-03 16:34:20 UTC

*** This bug has been marked as a duplicate of bug 437738 ***
Comment 4 Tyson Tan 2021-06-04 15:55:40 UTC
So it turned out it could be a digiKam bug after all. No other apps has this issue except Elisa/digiKam(7.3.0nightly)/Apper.

Related discussion:
https://bugs.kde.org/show_bug.cgi?id=437738#c15

Albert Astals Cid said:

(For Elisa) That's an elisa bug, open a bug for them, they either need to use KMainWindow (or some class that inherits from it) or call
      setTranslator(i18nc("NAME OF TRANSLATORS", "Your names"),
                    i18nc("EMAIL OF TRANSLATORS", "Your emails"));
manually on their KAboutData as stated in the KAboutData documentation

(For digiKam) it works on the last official release both using appimage and not using appimage, if it doesn't work on the nightly, i'd say that is their bug and not a kxmlgui bug either.
Comment 5 Tyson Tan 2021-06-04 16:17:40 UTC
It seems that the strings for the translators' credit is now missing from the original source...
Comment 6 Maik Qualmann 2021-06-04 19:12:37 UTC
The doc from KAboutData says that when using KMainWindow the translators are set automatically. I see in older digiKam AppImages that the translation tab is available. We haven't made any changes to the code on our part, I think. When I check KAboutData::translators() the list is empty. I guess that the translator involved is in the translation file. So I suspect the mistake there, I'll check out the current translation and look it up.

Incidentally, a look at other programs (Dolphin, Konsole) shows that no translators are manually specified in the code here.

Maik
Comment 7 Maik Qualmann 2021-06-04 20:35:33 UTC
Bug 438093 opened.

Maik
Comment 8 Maik Qualmann 2021-06-05 04:38:59 UTC
Git commit 7235cf4cb69f234c1b0549ccfba5077ce9e7536e by Maik Qualmann.
Committed on 05/06/2021 at 04:37.
Pushed by mqualmann into branch 'master'.

set translator for KAboutData manually
Related: bug 438093
FIXED-IN: 7.3.0

M  +3    -1    NEWS
M  +2    -0    core/app/main/main.cpp
M  +2    -0    core/showfoto/main/main.cpp

https://invent.kde.org/graphics/digikam/commit/7235cf4cb69f234c1b0549ccfba5077ce9e7536e
Comment 9 Tyson Tan 2021-06-05 11:10:01 UTC
Thank you Maik! :D