Bug 437632 - Dolphin launched via link does not display overlapping icon for Samba shares
Summary: Dolphin launched via link does not display overlapping icon for Samba shares
Status: CONFIRMED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 24.01.80
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-24 20:55 UTC by Patrick Silva
Modified: 2023-11-30 11:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screeen recording (991.02 KB, video/webm)
2021-05-24 20:55 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-05-24 20:55:33 UTC
Created attachment 138757 [details]
screeen recording

SUMMARY
Normally folders shared via Samba have an overlapping icon.
However, this icon is not displayed when I open Dolphin using a link
created on desktop. Please watch the attached screen recording.

STEPS TO REPRODUCE
1. create a link to your Home on desktop
2. create a Samba share in your Home
3. close Dolphin
4. open Dolphin using the link to Home created on desktop

EXPECTED RESULT
Dolphin launched via link should display overlapping icon for Samba shares

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Harald Sitter 2021-05-25 00:05:36 UTC
I feel like I've seen a similar bug report a couple months ago though for the life of me I can't remember what the specifics were.

What I **think** happens here is that since you are inside a symlink the effective path of the directory is /home/stalker/Desktop/stalker/Apps which dolphin then doesn't find in the database of samba usershares because the path there is /home/stalker/Apps. i.e. something (not necessarily dolphin) would need to at some point resolve the path (which includes a symlink) to the canonical file path (which includes no symlinks anywhere).
This is kind of problematic though because that would have to happen for every single directory that ever gets displayed in the view, potentially causing a lot of unnecessary disk access but certainly causing unnecessary power drain for basically only this niche corner case of share overlays (I dont think we have other overlays?). I'm not sure this is necessarily something we want to solve from an energy efficiency POV.
Comment 2 Patrick Silva 2021-05-25 00:14:36 UTC
(In reply to Harald Sitter from comment #1)
> I feel like I've seen a similar bug report a couple months ago though for
> the life of me I can't remember what the specifics were.

possibly bug 425678
Comment 3 Harald Sitter 2021-05-25 00:18:54 UTC
Thanks. That's it.

Of course there were no performance concern with the change to kdenetwork-filesharing since there's only ever one path we need to resolve. Quite a different story if it's 10k or more as would be the case here for dolphin's view.