Bug 437588 - Del removes Group Selected item and the second item also disappears from the Table view [patch]
Summary: Del removes Group Selected item and the second item also disappears from the ...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-ItemGroup (show other bugs)
Version: 7.3.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-24 05:26 UTC by HJ
Modified: 2023-10-15 10:25 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/digikam/-/commit/62449e779d6937b4f0234952fc3519cdbe018e85
Version Fixed In: 8.2.0
Sentry Crash Report:

Attachments
tableview.patch (1.24 KB, patch)
2021-05-24 16:50 UTC, Maik Qualmann 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description HJ 2021-05-24 05:26:44 UTC 
SUMMARY
Table view-Del removes Group Selected item and second item also disappears from search.
Menu View / Show All Grouped Items As Open menu is not selected.


STEPS TO REPRODUCE
1. Table view / Group / selected Group Selected item
2. Press Del
3. In the Window About to delete ... Group Selected item will be moved to the Trash
4. and after delete second group item also disappears from the search.
5. After the Similarity / Find Duplicates operation, the missing entry will reappear in the Table window

This does not with Group Selected item and Show All Grouped Items As Open menu is selected. 

OBSERVED RESULT
Causes confusion.

EXPECTED RESULT
The files situation after deletion is clearly and correctly visible

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION


This error occurs in Table view variants where Groups are visible, People, Search, Timeline, Dates, Labels, Tags, Albums.
For albums, the Group Selected item and the disappear of another group member are correct if the other one is in another album.


Hannes
Comment 1 Maik Qualmann 2021-05-24 16:50:09 UTC 
Created attachment 138750 [details]
tableview.patch

The patch is a first version and works, I'm not sure yet if it's the right one.

Maik
Comment 2 HJ 2021-05-25 07:32:16 UTC 
Grouped images disappear when the top image is deleted from the Table View and do not reappear after the Similarity / Find Duplicates operation.
After recovering the deleted image, the previous situation will be restored.

Hannes
Comment 3 caulier.gilles 2023-05-04 03:03:29 UTC 
@hannesj@hot.ee

Did you test the patch from Maik comment #1 ?

Gilles Caulier
Comment 4 caulier.gilles 2023-10-15 10:16:32 UTC 
Maik,

What's about to integrate this patch officially, in order in close also the bug #437646 ?

Gilles
Comment 5 Maik Qualmann 2023-10-15 10:25:28 UTC 
Git commit 62449e779d6937b4f0234952fc3519cdbe018e85 by Maik Qualmann.
Committed on 15/10/2023 at 12:24.
Pushed by mqualmann into branch 'master'.

fix grouped items in the table view when it is deleted
FIXED-IN: 8.2.0

M  +1    -1    NEWS
M  +15   -0    core/app/views/tableview/tableview_model.cpp

https://invent.kde.org/graphics/digikam/-/commit/62449e779d6937b4f0234952fc3519cdbe018e85