Bug 437555 - Default toolbar overflows now
Summary: Default toolbar overflows now
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords: regression, usability
: 441198 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-05-23 16:33 UTC by Andres Betts
Modified: 2021-09-15 20:19 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2021-05-23 16:33:41 UTC
Button labels are rather long for what they do. Because these labels are long, the default size terminal window does not allow for all controls to be shown at once.

Split view left/right
Split view top/bottom
Load new tab with 2x2 terminals
Load a new tab with layout 2x1 terminals
Load a new tab with layout 2x1 terminals

I would suggest that these live in a menu instead. If that's not possible, they should probably be shorter. For example:

Split vertical
Split horizontal
Split by 4
Split by 3

While this "may" not be technically accurate or less explicit, it is shorter and faster to process.
Comment 1 Nate Graham 2021-05-26 17:35:48 UTC
Yeah, IMO the real problem is that these "Load new tab*" actions should not be on the toolbar by default. There is never going to be enough room for them in any language unless you maximize the window on a 1080p screen.
Comment 2 Andres Betts 2021-06-09 01:33:11 UTC
I agree with you. It almost seems to me that these layout buttons need to live in a settings menu and the copy/paste/find buttons need to be moved to that place.
Comment 3 Bug Janitor Service 2021-09-14 12:34:06 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/484
Comment 4 nsprangers@gmail.com 2021-09-14 12:37:26 UTC
*** Bug 441198 has been marked as a duplicate of this bug. ***
Comment 5 Kurt Hindenburg 2021-09-15 20:19:45 UTC
Git commit 217ed2762b4aee632882977eccb85eb3effb101f by Kurt Hindenburg, on behalf of Nathan Sprangers.
Committed on 15/09/2021 at 20:19.
Pushed by hindenburg into branch 'master'.

Move splitview toolbar buttons into a button menu

The buttons have very long labels, which made the window too wide
or caused the toolbar to display a disclosure button to show all the
options.

This moves those buttons into a "Split View" toolbar button, which
fixes those issues and looks much nicer.

M  +2    -6    desktop/konsoleui.rc
M  +14   -1    src/ViewManager.cpp

https://invent.kde.org/utilities/konsole/commit/217ed2762b4aee632882977eccb85eb3effb101f