Bug 437525 - Layouts context-menu's icons become too big
Summary: Layouts context-menu's icons become too big
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: git (master)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-23 02:15 UTC by trmdi
Modified: 2021-05-24 14:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description trmdi 2021-05-23 02:15:11 UTC
Please see the screenshot: https://i.imgur.com/e72S0zQ.png
Comment 1 Michail Vourlakos 2021-05-23 05:17:10 UTC
That was on purpose but I understand that for that specific use case it might be better to use the same icon size.

For Docks, Panels subdialog this is not possible because the screens dialog would not be shown properly otherwise.
Comment 2 Michail Vourlakos 2021-05-23 06:16:07 UTC
Git commit ef383e8162219166e7a8aa6da32fa9022e1852f1 by Michail Vourlakos.
Committed on 23/05/2021 at 06:14.
Pushed by mvourlakos into branch 'master'.

respect icon size for layout:menuitem-icon

M  +1    -1    app/settings/generic/generictools.cpp
M  +2    -2    app/settings/generic/layoutscombobox.cpp
M  +1    -1    app/settings/settingsdialog/delegates/backgrounddelegate.cpp
M  +2    -2    app/settings/settingsdialog/delegates/layoutcmbitemdelegate.cpp
M  +3    -2    containmentactions/contextmenu/layoutmenuitemwidget.cpp

https://invent.kde.org/plasma/latte-dock/commit/ef383e8162219166e7a8aa6da32fa9022e1852f1
Comment 3 trmdi 2021-05-24 10:13:34 UTC
Yeah, it's fixed. But the width seems to be unnecessarily wide or is it your intention?

Screenshot: https://i.imgur.com/4RXbuPO.png
Comment 4 Michail Vourlakos 2021-05-24 14:16:57 UTC
Git commit 12c8643f62f71a762d1f0953e916c5bcf4664279 by Michail Vourlakos.
Committed on 24/05/2021 at 14:16.
Pushed by mvourlakos into branch 'master'.

reduce width for layouts contextmenu

M  +1    -1    containmentactions/contextmenu/layoutmenuitemwidget.cpp

https://invent.kde.org/plasma/latte-dock/commit/12c8643f62f71a762d1f0953e916c5bcf4664279