Bug 437461 - Tag panel from left side-bar has people items unsorted
Summary: Tag panel from left side-bar has people items unsorted
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (show other bugs)
Version: 7.2.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-21 13:34 UTC by spam-receiver
Modified: 2021-05-22 13:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.3.0
Sentry Crash Report:


Attachments
Screenshot of unsorted list (8.48 KB, image/png)
2021-05-21 13:34 UTC, spam-receiver
Details
Screenshot of "Personen" tab (19.96 KB, image/png)
2021-05-21 13:51 UTC, spam-receiver
Details

Note You need to log in before you can comment on or make changes to this bug.
Description spam-receiver 2021-05-21 13:34:06 UTC
Created attachment 138640 [details]
Screenshot of unsorted list

SUMMARY
DigiKam 7.2.0 on MS Windows, German locale.
Use the panel "Stichwörter" on left-hand side.
People from face tagging are collected under the entry "Personen".

The entries are unsorted, no specific ordering can be recognized, neither by forename, by surname nor by number of faces.

STEPS TO REPRODUCE
1. Have some faces tagged.
2. Open the left-hand side "Stichwörter" panel.
3. Open the item "Personen" which is the first item in the list.

OBSERVED RESULT
The items in "Personen" don't follow any obvious sorting, see attached screenshot.

EXPECTED RESULT
Sorting by name, forename, surname, number of face regios, number of photos, number of unconfirmed faces etc. 
Any sorting would be helpful...

SOFTWARE/OS VERSIONS
Windows: Win10, newest patch level
macOS: ./.
Linux/KDE Plasma: ./.
(available in About System)
KDE Plasma Version: ./.
KDE Frameworks Version: ./.
Qt Version: ./.

ADDITIONAL INFORMATION
MySQL/MariaDB  database on other server
Comment 1 Maik Qualmann 2021-05-21 13:43:13 UTC
Hmm, normally people with unconfirmed faces are actually sorted with their number of unconfirmed faces. If there are no more unconfirmed faces, alphabetical sorting is carried out. Since you don't have any unconfirmed faces, it actually looks strange. I'll check it out tonight to see if I can reproduce it.

Maik
Comment 2 spam-receiver 2021-05-21 13:51:16 UTC
Created attachment 138641 [details]
Screenshot of "Personen" tab
Comment 3 spam-receiver 2021-05-21 13:54:34 UTC
Actually, there are unconfirmed faces.
Please see the second screenshot showing the "Personen" tab.
Please note that the displayed numbers are completely inconsistent.

And yes, you're right, it's the same sorting on both tabs.

However, what's the use of sorting the _tags_ by number of unconfirmed _faces_?
I'd rather expect an alphabetical sorting here.
Comment 4 Maik Qualmann 2021-05-21 21:57:28 UTC
Git commit cc1a7f8365cd3904c99c65f3ad24b700ff92af60 by Maik Qualmann.
Committed on 21/05/2021 at 21:56.
Pushed by mqualmann into branch 'master'.

first step to fix people sorting
people view ok, tag view should ignore unconfirmed faces

M  +5    -3    core/libs/models/albumfiltermodel.cpp

https://invent.kde.org/graphics/digikam/commit/cc1a7f8365cd3904c99c65f3ad24b700ff92af60
Comment 5 Maik Qualmann 2021-05-21 22:00:16 UTC
Yes, users have wished that people with new unconfirmed faces be sorted to up. If there are no more unconfirmed faces, they are sorted alphabetically.

Maik
Comment 6 Maik Qualmann 2021-05-22 11:30:32 UTC
Git commit adb4a7af8d8ef1e2efb2bc84d082e90ca2b9c084 by Maik Qualmann.
Committed on 22/05/2021 at 11:29.
Pushed by mqualmann into branch 'master'.

fix people tag sorting from the People and Tags view
FIXED-IN: 7.3.0

M  +2    -1    NEWS
M  +7    -1    core/libs/models/abstractalbummodel.cpp
M  +9    -0    core/libs/models/abstractalbummodel.h
M  +10   -6    core/libs/models/albumfiltermodel.cpp
M  +5    -5    core/libs/models/albummodel.cpp
M  +0    -1    core/libs/models/albummodel.h

https://invent.kde.org/graphics/digikam/commit/adb4a7af8d8ef1e2efb2bc84d082e90ca2b9c084
Comment 7 spam-receiver 2021-05-22 13:09:30 UTC
(In reply to Maik Qualmann from comment #5)
> Yes, users have wished that people with new unconfirmed faces be sorted to
> up. If there are no more unconfirmed faces, they are sorted alphabetically.
> 
> Maik

Hello Maik!
Thank you very much for the *immediate* response to my issue report and for fixing it.

In my irrelevant opinion, too, sorting "unconfirmed first, then alphabetically" on the "People" tab is perfect.

I'm looking forward to 7.3!