Bug 437460 - "Apply" button remains greyed out after editing OSD time with keyboard
Summary: "Apply" button remains greyed out after editing OSD time with keyboard
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_kwinvirtualdesktops (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-21 13:32 UTC by Patrick Silva
Modified: 2021-05-24 19:13 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22


Attachments
screeen recording (1.52 MB, video/webm)
2021-05-21 21:56 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-05-21 13:32:40 UTC
STEPS TO REPRODUCE
1. open Virtual Desktops KCM
2. check "Show on screen display when switching'
3. click on Apply button
4. edit OSD time using your keyboard

OBSERVED RESULT
you can not apply the change in OSD time because Apply button is greyed out.

EXPECTED RESULT
active Apply button

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Nate Graham 2021-05-21 15:35:06 UTC
Works for me. Can you attach a screen recording, maybe?
Comment 2 Patrick Silva 2021-05-21 21:56:21 UTC
Created attachment 138661 [details]
screeen recording

Here is the screen recording.
When I press TAB key, Apply buttom is activated but typed time
resets to 0 ms. lol
Comment 3 Nicolas Fella 2021-05-22 11:21:32 UTC
This seems to be fixed with https://invent.kde.org/plasma/kwin/-/merge_requests/1024
Comment 4 Nate Graham 2021-05-24 19:13:23 UTC
Git commit 5484b846b3869a8adca4cf801ca296b94017179e by Nate Graham, on behalf of David Edmundson.
Committed on 24/05/2021 at 18:51.
Pushed by ngraham into branch 'master'.

[kcmkwin/kwindesktop] Implement valueFromText in a spinbox

If textFromValue is set, valueFromText must be.

A lot of other implemenetations were using parseInt() which fails at
reading "3,000" due to the comma. Qt's fromLocaleString handles that but
needs any text stripping.

This implementation isn't perfect, but really we need to work on a good
upstream solution.

M  +1    -0    src/kcmkwin/kwindesktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/kwin/commit/5484b846b3869a8adca4cf801ca296b94017179e
Comment 5 Nate Graham 2021-05-24 19:13:43 UTC
Git commit b8580339b44e376dbf035cb7a93096f71319ee54 by Nate Graham, on behalf of David Edmundson.
Committed on 24/05/2021 at 19:11.
Pushed by ngraham into branch 'Plasma/5.22'.

[kcmkwin/kwindesktop] Implement valueFromText in a spinbox

If textFromValue is set, valueFromText must be.

A lot of other implemenetations were using parseInt() which fails at
reading "3,000" due to the comma. Qt's fromLocaleString handles that but
needs any text stripping.

This implementation isn't perfect, but really we need to work on a good
upstream solution.


(cherry picked from commit 5484b846b3869a8adca4cf801ca296b94017179e)

M  +1    -0    src/kcmkwin/kwindesktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/kwin/commit/b8580339b44e376dbf035cb7a93096f71319ee54