Bug 437459 - Discarding changes after clicking "defaults" button does not bring back removed virtual desktops
Summary: Discarding changes after clicking "defaults" button does not bring back remov...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_kwinvirtualdesktops (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-21 13:11 UTC by Patrick Silva
Modified: 2021-05-24 12:02 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/kwin/-/commit/7f36f012478722e0cda859b28fdd7cd2d63f4225
Version Fixed In: 5.22

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-05-21 13:11:06 UTC 
STEPS TO REPRODUCE
1. open Virtual Desktops KCM
2. one virtual desktop is available by default in Virtual Desktops KCM.
Add 1 or more and click on Apply button.
3. click on Defaults button (just one virtual desktop remains)
4. go to another KCM
5. when System Settings prompts to save/discard change, click on Discard button

OBSERVED RESULT
you have lost the virtual desktop(s) added in the step 2 despite defaults were discarted

EXPECTED RESULT
virtual desktop(s) added in the step 2 should not be immediately removed
when we click on Defaults button. Only remove it/them if we confirm defaults
with click on Apply button of the KCM or Apply button of save/discard prompt.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Nate Graham 2021-05-21 15:34:05 UTC 
Can confirm.
Comment 2 Nicolas Fella 2021-05-22 11:36:44 UTC 
I cannot reproduce
Comment 3 Nicolas Fella 2021-05-22 11:41:42 UTC 
I can reproduce it somewhat differently:

1. Start with default settings
2. Add a desktop
3. Change rows from 2 to 3
4. Apply
5. Click "Defaults"
6. Change KCMs

It doesn't prompt to save/discard the pending settings
Comment 4 Nicolas Fella 2021-05-22 11:44:44 UTC 
My issue seems to be fixed with https://invent.kde.org/plasma/kwin/-/merge_requests/1025