Bug 437383 - Move the System Settings' own settings to the hamburger menu
Summary: Move the System Settings' own settings to the hamburger menu
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.21.90
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-19 23:38 UTC by Lua
Modified: 2021-09-16 14:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23.80
Sentry Crash Report:


Attachments
Audio and battery applets (407.85 KB, image/png)
2021-05-19 23:38 UTC, Lua
Details
System Settings own settings (32.26 KB, image/png)
2021-05-19 23:40 UTC, Lua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lua 2021-05-19 23:38:57 UTC
Created attachment 138581 [details]
Audio and battery applets

SUMMARY
Other parts of the system have its settings in the hamburger menu like the battery applet (5.22) and the audio applet. System Settings settings have only three options, creating an inconsistency and unnecessary clicks to change the options.

STEPS TO REPRODUCE


OBSERVED RESULT


EXPECTED RESULT
The System Settings settings being located in the hamburger menu.

SOFTWARE/OS VERSIONS


ADDITIONAL INFORMATION
Comment 1 Lua 2021-05-19 23:40:11 UTC
Created attachment 138582 [details]
System Settings own settings
Comment 2 Nate Graham 2021-05-20 17:48:03 UTC
Actually the fact that the hamburger menus have duplicated "Configure" actions in them at all is a bug which was just fixed. :) Now the hamburger menu will only have a configure action in it if it's different from the one next to the Pin button (which is something I plan to fix in Plasma 5.23).
Comment 3 Lua 2021-05-21 08:45:34 UTC
Sorry, but I didn't understand what you said D: What I was trying to say is that the window has only 3 options and they could be in the (hamburger) menu.
Comment 4 Nate Graham 2021-06-02 16:42:11 UTC
OK.
Comment 5 Ismael Asensio 2021-09-16 14:21:07 UTC
Git commit 8f9b9c88faa7958769ec84cfb7ebc859dad167ae by Ismael Asensio.
Committed on 16/09/2021 at 14:19.
Pushed by iasensio into branch 'master'.

Remove Settings Dialog

This dialog seemed somehow superfluous and redundant
(system settings' settings dialog)

The view modes (icons/sidebar) are now accesible from specific
actions (`Switch to ... View`), instead of the `Configure..` button.

The remaining "Show Tooltip" option has been removed
FIXED-IN: 5.23.80

M  +0    -1    app/CMakeLists.txt
M  +23   -90   app/SettingsBase.cpp
M  +2    -10   app/SettingsBase.h
D  +0    -37   app/configDialog.ui
M  +2    -0    app/main.cpp
M  +0    -4    app/systemsettings.kcfg
M  +0    -10   core/BaseMode.cpp
M  +0    -10   core/BaseMode.h
M  +5    -5    sidebar/SidebarMode.cpp

https://invent.kde.org/plasma/systemsettings/commit/8f9b9c88faa7958769ec84cfb7ebc859dad167ae