Bug 437345 - Small and Medium icon sizing result in list items with the same height; only the icon size differs
Summary: Small and Medium icon sizing result in list items with the same height; only ...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: places (show other bugs)
Version: 21.04.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-05-19 09:16 UTC by popov895
Modified: 2021-06-01 16:55 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 21.08
Sentry Crash Report:


Attachments
Before and after (118.83 KB, image/png)
2021-05-19 09:16 UTC, popov895
Details
Item size: panel vs view (41.07 KB, image/jpeg)
2021-05-19 11:37 UTC, popov895
Details
Icons: small vs medium (35.41 KB, image/jpeg)
2021-05-19 13:12 UTC, popov895
Details

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2021-05-19 09:16:03 UTC
Created attachment 138554 [details]
Before and after

SUMMARY

After upgrading to KDE Gear 21.04.1, the items in the Places panel have become large, while the icon and font sizes have not changed. At the same time, switching the icon size between Small and Medium doesn't change the size of the item itself. Looks like items with small icons got extra spacing and now this panel contains less information than before the update. In addition, it looks bad.

If this was done on purpose, please add an option to disable this extra spacing.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: openSUSE Tumbleweed 20210517 / X11
KDE Plasma Version: 5.21.5
KDE Gear Version: 21.04.1
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2
Comment 2 popov895 2021-05-19 11:37:57 UTC
Created attachment 138558 [details]
Item size: panel vs view

Disagree with you, the items in the Places panel are well readable without this extra spacing. In your case, you just need to switch to Medium icon size. Also, you can see from the screenshots of other file managers from your MR, they all use a compact arrangement of items on the sidebar.
Comment 3 Harald Sitter 2021-05-19 12:17:59 UTC
I haven't made any argument whatsoever (:
Comment 4 popov895 2021-05-19 13:12:31 UTC
Created attachment 138563 [details]
Icons: small vs medium

Another feature of your changes is that items with small and medium icons are now the same size.
Comment 5 Paul 2021-05-19 14:04:36 UTC
Tend to agree with the OP on this issue, far too much padding...

What would be good is if the padding value could be user defined, preferably by manually editing a configuration file, thus retaining the "simplicity of design" for those who don't want to change the defaults.
Comment 6 Nate Graham 2021-05-19 17:49:19 UTC
(In reply to popov895 from comment #4)
> Created attachment 138563 [details]
> Icons: small vs medium
> 
> Another feature of your changes is that items with small and medium icons
> are now the same size.
That's true. Now it's a bit silly, and we might as well use the Medium size by default. Which in fact would improve consistency with other list items elsewhere.
Maybe that's the change we should have made instead of the one done in https://invent.kde.org/system/dolphin/-/merge_requests/78
Comment 7 Bug Janitor Service 2021-05-22 12:30:10 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/213
Comment 8 Nate Graham 2021-05-29 23:52:32 UTC
Git commit df9ae6c24ec57afd063bfa7ff25160efdb913ce9 by Nate Graham, on behalf of Eugene Popov.
Committed on 29/05/2021 at 22:16.
Pushed by ngraham into branch 'master'.

Use SmallMedium icon size in the Places panel as default

This patch makes the Places panel to use SmallMedium icon size as default, making it easier to read. It also removes extra spacing from items with small icons (reverts e9a39700 and 56888a56).

M  +2    -1    src/panels/places/dolphin_placespanelsettings.kcfg

https://invent.kde.org/system/dolphin/commit/df9ae6c24ec57afd063bfa7ff25160efdb913ce9
Comment 9 popov895 2021-06-01 16:55:14 UTC
Thanks!