Bug 437227 - Install button goes out of page in widescreen mode and a non-default backend has a really long name
Summary: Install button goes out of page in widescreen mode and a non-default backend ...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-17 01:47 UTC by Carl Schwan
Modified: 2021-08-06 15:29 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/discover/commit/8689559186feee6f1a345e00a7edf99ab4eca3b6
Version Fixed/Implemented In: 5.23
Sentry Crash Report:

Attachments
Discover (20.67 KB, image/png)
2021-05-17 01:47 UTC, Carl Schwan 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Schwan 2021-05-17 01:47:08 UTC 
Created attachment 138493 [details]
Discover

SUMMARY


STEPS TO REPRODUCE
1. Open Discover with the flathub backend enabled
2. Scroll on the Application pages

OBSERVED RESULT

Weird install button (see screenshot)

SOFTWARE/OS VERSIONS
Discover: master
Kirigami master
Qt Version: 5.15.3

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-05-18 21:43:06 UTC 
Heh when you have Flathub as your default backend, apps from the distro will show the name of the distro in the install button to differentiate those apps from the FlatHub ones, but on openSUSE Tumbleweed, this is a really really long string, and Buttons don't elide by default (and if they did, it would look weird).

Can confirm.
Comment 2 Bug Janitor Service 2021-08-05 16:59:22 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/151
Comment 3 Nate Graham 2021-08-06 15:29:58 UTC 
Git commit 8689559186feee6f1a345e00a7edf99ab4eca3b6 by Nate Graham.
Committed on 06/08/2021 at 15:29.
Pushed by ngraham into branch 'master'.

Limit very long backend names in InstallApplicationButton

Otherwise the button may be so long that it elides the app text or even
overflows outside of the layout!
Related: bug 439087
FIXED-IN: 5.23

M  +8    -1    discover/qml/InstallApplicationButton.qml

https://invent.kde.org/plasma/discover/commit/8689559186feee6f1a345e00a7edf99ab4eca3b6