Bug 437203 - Dots on the new calendar widget are sometimes positioned wrong
Summary: Dots on the new calendar widget are sometimes positioned wrong
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.82.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-05-16 13:36 UTC by Riccardo Robecchi
Modified: 2021-07-18 19:37 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/plasma-framework/commit/11e2ae62baf87daf2135ce55d1ebfdf515969572
Version Fixed In: 5.85

Attachments
Screenshot of the widget (31.57 KB, image/png)
2021-05-16 13:36 UTC, Riccardo Robecchi 		Details
tiny (58.41 KB, image/png)
2021-05-18 21:31 UTC, Carl Schwan 		Details
Widget with two calendars (39.97 KB, image/png)
2021-05-19 10:30 UTC, Riccardo Robecchi 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Riccardo Robecchi 2021-05-16 13:36:47 UTC 
Created attachment 138485 [details]
Screenshot of the widget

SUMMARY
The new dots introduced with Frameworks 5.82 are really hard to spot with a dark theme. It seems like the colour is hard coded, so it only really works with light themes. On my 14" notebook I can't see the dots unless I get ~30 cm from the screen, thus making the dots way less useful than the old triangles. Moreover, when using non-default calendar widgets (e.g. Event Calendar) the date is too big and ends up under the dots, making readability worse.

STEPS TO REPRODUCE
1. Set a dark theme
2. Open a calendar widget

OBSERVED RESULT
The new dots have a hard-coded colour and position which are difficult to read.

EXPECTED RESULT
The dots follow the theme colours, are more readable with a dark theme and do not overlap the date.

SOFTWARE/OS VERSIONS
Linux: KDE neon
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-05-18 21:24:11 UTC 
The color is not hardcoded; it respects your active color scheme, and this is working fine for me. The problem seems to be the positioning there.
Comment 2 Carl Schwan 2021-05-18 21:31:38 UTC 
It seems that the new calendar design doesn't support as nicely small calendars ( see screenshot). I see two ways to fix it.

* Don't make it possible for users to create tinny calendars
* Don't display the events dots for tinny calendars

Probably the second solution is the best.
Comment 3 Carl Schwan 2021-05-18 21:31:48 UTC 
Created attachment 138547 [details]
tiny
Comment 4 Riccardo Robecchi 2021-05-19 10:30:32 UTC 
Created attachment 138555 [details]
Widget with two calendars

(In reply to Nate Graham from comment #1)
> The color is not hardcoded; it respects your active color scheme, and this
> is working fine for me. The problem seems to be the positioning there.

You are right. After reading your comment I did a few experiments and I understood what happens: the colour of the dot does not respect the colour scheme, it is the same as the calendar in KOrganizer, so that's why changing the theme did not lead to a change in the colour (and led me to conclude it was hardcoded). See attached screenshot for reference: I enabled a second calendar and its colour showed up, and changing its colour in KOrganizer also changed it in the widget.

This doesn't mean that the issue is not there anyway, as the colours I use are perfectly distinguishable on light themes, but not on dark ones.
Comment 5 Nate Graham 2021-07-18 19:36:52 UTC 
Git commit 11e2ae62baf87daf2135ce55d1ebfdf515969572 by Nate Graham, on behalf of Carl Schwan.
Committed on 18/07/2021 at 19:36.
Pushed by ngraham into branch 'master'.

Add a bit more contrast to event indicator in calendar

Now make it darker on light theme and lighter on dark theme

M  +2    -1    src/declarativeimports/calendar/qml/DayDelegate.qml

https://invent.kde.org/frameworks/plasma-framework/commit/11e2ae62baf87daf2135ce55d1ebfdf515969572
Comment 6 Nate Graham 2021-07-18 19:37:44 UTC 
Let's see if that's good enough. Please re-open if you continue to see problems here once Frameworks 5.85 is released. Thanks!