Bug 437105 - Whole system tray is highlighted with a blue line after enabling/disabling "Keep open" feature of active applet
Summary: Whole system tray is highlighted with a blue line after enabling/disabling "K...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray widget (show other bugs)
Version: 5.21.90
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-14 17:15 UTC by Patrick Silva
Modified: 2021-05-24 20:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22.0
Sentry Crash Report:


Attachments
screen recording (1.19 MB, video/webm)
2021-05-14 17:15 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-05-14 17:15:13 UTC
Created attachment 138425 [details]
screen recording

SUMMARY
Title says it all. Please watch the attached screen recording.

EXPECTED RESULT
blue line of system tray should not change when we enable/disable "Keep open" feature.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.21.90
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Nate Graham 2021-05-18 20:47:37 UTC
Can reproduce, but maybe this is actually intentional? Konrad?
Comment 2 Konrad Materka 2021-05-21 20:37:01 UTC
(In reply to Nate Graham from comment #1)
> Can reproduce, but maybe this is actually intentional? Konrad?

This is unintentional. It must be corner case in another corner case that was fixed :/ I need to check it.
Comment 3 Bug Janitor Service 2021-05-21 21:59:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/876
Comment 4 Nate Graham 2021-05-24 16:06:28 UTC
Git commit 07b3b10de7d09b8918bd237cf0eca9d3fe868c64 by Nate Graham, on behalf of Konrad Materka.
Committed on 24/05/2021 at 16:06.
Pushed by ngraham into branch 'master'.

[applets/systemtray] Fix highlight on applet pin

Sometimes parent component on the applet is not fully updated - for
example effectiveStatus is not yet read from the model. In such case it
will have default value leading to undesired effect.

Call all `updateHighlightedItem` in `Qt.callLater` so that it is called
in next event loop. As a bonus it is called only once, which can improve
performance.
FIXED-IN: 5.22.0

M  +6    -6    applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

https://invent.kde.org/plasma/plasma-workspace/commit/07b3b10de7d09b8918bd237cf0eca9d3fe868c64
Comment 5 Nate Graham 2021-05-24 16:23:29 UTC
Git commit 1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0 by Nate Graham, on behalf of Konrad Materka.
Committed on 24/05/2021 at 16:23.
Pushed by ngraham into branch 'Plasma/5.22'.

[applets/systemtray] Fix highlight on applet pin

Sometimes parent component on the applet is not fully updated - for
example effectiveStatus is not yet read from the model. In such case it
will have default value leading to undesired effect.

Call all `updateHighlightedItem` in `Qt.callLater` so that it is called
in next event loop. As a bonus it is called only once, which can improve
performance.
FIXED-IN: 5.22.0


(cherry picked from commit 07b3b10de7d09b8918bd237cf0eca9d3fe868c64)

M  +6    -6    applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

https://invent.kde.org/plasma/plasma-workspace/commit/1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0
Comment 6 Konrad Materka 2021-05-24 20:51:12 UTC
(In reply to Nate Graham from comment #5)
> Git commit 1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0 by Nate Graham, on
> behalf of Konrad Materka.
> Pushed by ngraham into branch 'Plasma/5.22'.

Thank you, Nate!