This is possibly an issue mainly for shortcuts If you're on a certain frame and layer and increase hold frames (for example)without an active selection you expect the frame count to increase. This does happen But then when you press to go to the next layer the selection remains on the previous layer. so if you now increase hold frames the previous layer will get an increase in hold frames This is not really fluid and logical. This is not expected behaviour. If you however make the same operation on a range selection it is save to say you're probably activly working with that range. So the behaviour i explained above should probably ONLY be implemented for when no range is actively selected The active frame SHOULD follow the layer selection automatically
I'm not entirely sure about this, since you can also select frames that don't belong to the currently active layer. Would restricting this behavior to only when multiple frames are selected on a single layer be good enough? (As in, whenever a selection of a frame on the non active layer is present, this behavior would be disabled?)
(In reply to Eoin O'Neill from comment #1) > I'm not entirely sure about this, since you can also select frames that > don't belong to the currently active layer. > > Would restricting this behavior to only when multiple frames are selected on > a single layer be good enough? (As in, whenever a selection of a frame on > the non active layer is present, this behavior would be disabled?) I dont understand your example My proposal is that if you make a single frame selection (or usually no selection at all even), everything should work as it does now, BUT when you move the timeline marker through shortcuts (left right, up and down) the selection should follow the frame that is active at that time frame marker and layer. Selecting a range on a layer, or multiple layer is a clear intent to do some manipulations and work with that range, in that case this new proposed behavioure would not be needed. Maybe if you'rez still hesitent this could be a special mode on the timeline "active frame" mode where, if active the proposed behaviour happens, and if not the current sticky frame behaviour happens
> Selecting a range on a layer, or multiple layer is a clear intent to do some manipulations and work with that range, in that case this new proposed behavioure would not be needed. OK -- I think I just misunderstood this point. I'll look into this. I didn't realize there was a difference between these hotkeys as you've described and I'll test it out.
Git commit 1df3c81d4b592c0a1bc85ab738e6a43cbcbd4f6e by Eoin O'Neill. Committed on 18/05/2021 at 19:53. Pushed by eoinoneill into branch 'master'. KisAnimTimelineFramesView: Single frame selection of "current time" on "active layer" now follows during layer traversal. It's a bit of a mouthful, but it basically allows the user to have a frame selected on the current time persist between layer switching. Useful for PageUp / PageDown navigation and doing a frame operation such as insert hold frame. M +17 -4 plugins/dockers/animation/KisAnimTimelineFramesModel.cpp M +1 -0 plugins/dockers/animation/KisAnimTimelineFramesModel.h M +17 -1 plugins/dockers/animation/KisAnimTimelineFramesView.cpp M +4 -0 plugins/dockers/animation/KisAnimTimelineFramesView.h https://invent.kde.org/graphics/krita/commit/1df3c81d4b592c0a1bc85ab738e6a43cbcbd4f6e
Bollebib: Please test this feature out via Krita Next in a few days and let me know what you think.
(In reply to Eoin O'Neill from comment #4) > Git commit 1df3c81d4b592c0a1bc85ab738e6a43cbcbd4f6e by Eoin O'Neill. > Committed on 18/05/2021 at 19:53. > Pushed by eoinoneill into branch 'master'. > > KisAnimTimelineFramesView: Single frame selection of "current time" on > "active layer" > now follows during layer traversal. > > It's a bit of a mouthful, but it basically allows the user to have a frame > selected on the current > time persist between layer switching. Useful for PageUp / PageDown > navigation and doing a frame operation > such as insert hold frame. > > M +17 -4 plugins/dockers/animation/KisAnimTimelineFramesModel.cpp > M +1 -0 plugins/dockers/animation/KisAnimTimelineFramesModel.h > M +17 -1 plugins/dockers/animation/KisAnimTimelineFramesView.cpp > M +4 -0 plugins/dockers/animation/KisAnimTimelineFramesView.h > > https://invent.kde.org/graphics/krita/commit/ > 1df3c81d4b592c0a1bc85ab738e6a43cbcbd4f6e (In reply to Eoin O'Neill from comment #5) > Bollebib: Please test this feature out via Krita Next in a few days and let > me know what you think. okay i will need to test it....what do i need to do to saveguard my settings?