Bug 437020 - Cancel ALL Composition Export
Summary: Cancel ALL Composition Export
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 4.4.3
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Emmet O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-13 09:52 UTC by Bollebib
Modified: 2024-09-12 00:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bollebib 2021-05-13 09:52:37 UTC
Sometimes you need to cancel export because you made a mistake that you notice or change you need to make.


But while you can cancel an export you can only do it for the current composition, and all the following compositions will still try and export.



There is also no way of cancelling normal composition exports, so maybe a general way to cancel both normal and animation compositions would be a good thing
Comment 1 Eoin O'Neill 2021-05-13 20:08:18 UTC
Yes, this needs to be improved. Some changes need to be made to the exporting UI to get there though.
Comment 2 Emmet O'Neill 2024-09-12 00:17:51 UTC
Git commit ad76c609277e031a03afeaa5b6eafdd0f834b943 by Emmet O'Neill.
Committed on 12/09/2024 at 00:16.
Pushed by emmetoneill into branch 'master'.

Compositions Docker: Allow composition export to be canceled.

This isn't easy to properly test given the relatively
small size of some of my animation test files, but
I believe this should allow the animation compositions
export process to be entirely canceled by the user.

(Previously canceling the export of 1 composition
wouldn't cancel the entire process, thus wasting
a lot of time when exporting multiple large animated
compositions.)

M  +13   -10   libs/ui/animation/KisAnimationRender.cpp
M  +4    -2    libs/ui/animation/KisAnimationRender.h
M  +3    -1    plugins/dockers/compositiondocker/compositiondocker_dock.cpp

https://invent.kde.org/graphics/krita/-/commit/ad76c609277e031a03afeaa5b6eafdd0f834b943
Comment 3 Emmet O'Neill 2024-09-12 00:21:30 UTC
Hi Bollebib, I *think* I've fixed this but it's difficult for me to properly test due to the small size of many of my animations and test files.

Please give this fix attempt a try whenever you can and let me know if it works better for you.
If not, let's reopen this bug report and I'll take another stab at it as soon as I can.