Bug 436964 - The video import dialog should have a cancel button
Summary: The video import dialog should have a cancel button
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-12 12:33 UTC by wolthera
Modified: 2024-09-09 23:05 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/krita/-/commit/4c62b784bae589e480988bb35b8c74438db752d5
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description wolthera 2021-05-12 12:33:51 UTC 
SUMMARY
When pressing the X button on the video import dialog, it seems it must be pressed multiple times

STEPS TO REPRODUCE
1. Select a large number (3000) of frames from a video file.
2. Import them.
3. Press the X button now rapidly because of how frightening this huge amount of frames is.
Comment 1 Halla Rempt 2021-05-12 12:38:52 UTC 
Actually, clicking the close button doesn't even seem to cancel anything. Not that the close button is supposed to be a cancel button.
Comment 2 Emmet O'Neill 2024-09-09 23:05:43 UTC 
Git commit 4c62b784bae589e480988bb35b8c74438db752d5 by Emmet O'Neill.
Committed on 09/09/2024 at 23:02.
Pushed by emmetoneill into branch 'master'.

Video Import: Allow import process to be canceled.

Previously, closing the "import video as animation"
progress dialog simply reopen instead of canceling.
Closing the progress dialog now properly cancels the
ffmpeg subprocess.

M  +12   -2    libs/ui/animation/KisDlgImportVideoAnimation.cpp
M  +9    -3    libs/ui/animation/KisFFMpegWrapper.cpp
M  +1    -1    libs/ui/animation/KisFFMpegWrapper.h

https://invent.kde.org/graphics/krita/-/commit/4c62b784bae589e480988bb35b8c74438db752d5