Bug 436816 - If a shortcut component is deleted while being viewed, its name sometimes becomes unreadable
Summary: If a shortcut component is deleted while being viewed, its name sometimes bec...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keys (other bugs)
Version First Reported In: unspecified
Platform: Other Other
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-09 09:44 UTC by Kishore Gopalakrishnan
Modified: 2021-05-13 13:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.23
Sentry Crash Report:


Attachments
Screenshot showing the issue (43.78 KB, image/png)
2021-05-09 09:44 UTC, Kishore Gopalakrishnan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2021-05-09 09:44:37 UTC
Created attachment 138266 [details]
Screenshot showing the issue

SUMMARY
When we delete all shortcuts for a component but do not apply the change, the name of the component in the sidebar is greyed out. However, in certain situations, the name becomes white (and thus impossible to read in the default theme) instead of being greyed out.

STEPS TO REPRODUCE
1. Go to System Settings > shortcuts > shortcuts.
2. Click on an item (in the sidebar which shows categories Applications, System Services etc.) to show the corresponding shortcuts.
3. Click the dustbin icon near the name of the viewed component.
4. Hover over another item (but do not click it).

OBSERVED RESULTS
The name of the deleted item is invisible, but the icon is shown greyed out (see attached image)

EXPECTED RESULTS
Name of the deleted item should be also be shown greyed out.


SOFTWARE/OS VERSIONS
System Settings version: 5.21.5 (couldn't find this in the list of versions)
Operating System: Arch Linux
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.81.0
Qt Version: 5.15.2
Kernel Version: 5.12.1-arch1-1
OS Type: 64-bit
Graphics Platform: X11
Graphics Processor: AMD Radeon™ Vega 8 Graphics

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-05-10 23:03:34 UTC
Can confirm. This is because this list uses totally custom list items with coloration heuristics copied from elsewhere which are not quite in sync with the general stuff. It needs to be ported to use Kirigami.BasicListItem. I tried a few weeks ago but got stuck on the inability to keep the undo icon at full opacity in this state without it feeling hacky. Maybe I'll try again.
Comment 2 Bug Janitor Service 2021-05-11 03:14:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/460
Comment 3 Nate Graham 2021-05-11 22:57:27 UTC
Git commit a73ce76190d2ba08bf3c0f492e9f06a67beeceac by Nate Graham.
Committed on 11/05/2021 at 22:56.
Pushed by ngraham into branch 'master'.

Add new fadeContent property to BasicListItem

This new property can be used to make the main content of a
BasicListitem have a disabled or de-emphasized look while preserving
full opacity for any leading or trailing items.

M  +15   -3    src/controls/BasicListItem.qml

https://invent.kde.org/frameworks/kirigami/commit/a73ce76190d2ba08bf3c0f492e9f06a67beeceac
Comment 4 Nate Graham 2021-05-13 13:29:23 UTC
Git commit 1698d42f525049e2bfc402b52c0e4642060ba5b4 by Nate Graham.
Committed on 13/05/2021 at 13:28.
Pushed by ngraham into branch 'master'.

[kcms/keys] Port sidebar list item to Kirigami.BasicListItem

This commit ports the Shortcuts KCM's sidebar list items to use
Kirigami.BasicListItem, which fixes a binding loops and some bugs
related to incorrect colors caused by the custom content item, and
gets rid of another bespoke list item implementation.  The embedded
hover ToolButtons are changed to regular Buttons to avoid losing their
hover appearance entirely due to differences in BasicListItem's
coloration semantics.

The result has minor visual differences but is functionally the same.
FIXED-IN: 5.23

M  +25   -35   kcms/keys/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/1698d42f525049e2bfc402b52c0e4642060ba5b4