Bug 436683 - Honor EXIF image orientation metadata when adding images
Summary: Honor EXIF image orientation metadata when adding images
Status: RESOLVED FIXED
Alias: None
Product: tellico
Classification: Applications
Component: general (show other bugs)
Version: 3.4
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-06 11:28 UTC by Robby Stephenson
Modified: 2021-05-06 11:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 3.4.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robby Stephenson 2021-05-06 11:28:26 UTC
From https://forum.kde.org/viewtopic.php?f=200&t=171004&sid=fee538ebb6fe89704a15dbdc9dfafdca

Tellico should recognize and account for image metadata indicating a rotation
Comment 1 Robby Stephenson 2021-05-06 11:31:58 UTC
Git commit ae5202f8868c3816bdaef78526865c972f4f4b74 by Robby Stephenson.
Committed on 06/05/2021 at 11:29.
Pushed by rstephenson into branch '3.4'.

Use QImageReader to account for image orientation metadata

Inside the QImage constructor, use QImageReader explicitly and set
autoTransform(). Add a unit test.

Benchmarks seems to say this loading approach may even be slightly
faster than before. Since the QImage:load() method uses QImageReader
internally as well, I don't believe there would be a downside to
creating a new QImageReader every time.
FIXED-IN: 3.4.1

M  +10   -5    src/images/image.cpp
A  +-    --    src/tests/data/img1.jpg
A  +-    --    src/tests/data/img2.jpg
M  +16   -1    src/tests/imagetest.cpp
M  +2    -1    src/tests/imagetest.h

https://invent.kde.org/office/tellico/commit/ae5202f8868c3816bdaef78526865c972f4f4b74