Bug 436666 - Elisa doesn't show credit for its translators in About dialogue
Summary: Elisa doesn't show credit for its translators in About dialogue
Status: CONFIRMED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 21.04.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-06 01:23 UTC by Tyson Tan
Modified: 2021-10-16 14:11 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2021-05-06 01:23:57 UTC
Elisa doesn't show credit for its translators in About dialogue. Although it does have YOUR NAME/EMAIL strings in the POT files. It'd be nice if we can add a Translators tab in the About dialogue.
Comment 1 Nate Graham 2021-05-06 16:36:59 UTC
Just for Elisa, or for every app? I don't see translators listed in any other KDE apps.
Comment 2 Tyson Tan 2021-05-07 00:54:56 UTC
If you are using English, the Translators tab won't show up in About dialogue. Switch to another locale with proper translation, and the Translators tab will show you only the translators of that specific locale.

I've just checked on my system:

Those have Translators tab:
Krita, Kate, Dolphin, Okular, Gwenview, Krita, digiKam, Kdenlive, Konsole, Dragonplayer, Juk, Kcalc, System monitor, Ksystemlog, Spectacle, Marble

Those have no Translators tab:
Elisa, Apper
Comment 3 Nate Graham 2021-05-07 13:37:53 UTC
Got it, thanks.
Comment 4 Tyson Tan 2021-05-27 13:36:24 UTC
Seems to be a KDE Frameworks issue. New versions of digiKam also has this problem. I have reported the bug to kxmlgui where the related translations resides: https://bugs.kde.org/show_bug.cgi?id=437738
Comment 5 Nate Graham 2021-05-27 13:56:37 UTC
OK. :)

*** This bug has been marked as a duplicate of bug 437738 ***
Comment 6 Tyson Tan 2021-06-04 15:53:57 UTC
So it turned out it could be a Elisa bug after all. No other apps has this issue except Elisa/digiKam(7.3.0nightly)/Apper.

Related discussion:
https://bugs.kde.org/show_bug.cgi?id=437738#c15

Albert Astals Cid said:

That's an elisa bug, open a bug for them, they either need to use KMainWindow (or some class that inherits from it) or call
      setTranslator(i18nc("NAME OF TRANSLATORS", "Your names"),
                    i18nc("EMAIL OF TRANSLATORS", "Your emails"));
manually on their KAboutData as stated in the KAboutData documentation
Comment 7 Nate Graham 2021-06-07 12:50:19 UTC
Indeed, Elisa does not use KMainWindow so we we need to use it, or add the translators manually.
Comment 8 Maik Qualmann 2021-06-07 13:15:14 UTC
But it must also be a bug in the KF5 framework. But I also see that it works in programs like Dolphin or Gwenview. With digiKam we use KXmlGuiWindow and thus also KMainWindow. The translators have so far been added automatically. Only not recently. We have added it to KAboutData manually at the moment.

Maik
Comment 9 Nate Graham 2021-06-07 15:38:37 UTC
Dolphin and Gwenview use KMainWindow