Bug 436593 - Most items in "Application Menu" are redundant
Summary: Most items in "Application Menu" are redundant
Status: RESOLVED FIXED
Alias: None
Product: Skanpage
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Stippich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-04 16:55 UTC by Nate Graham
Modified: 2021-05-04 19:38 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-05-04 16:55:27 UTC
The first four options are already visible by default in the non-modifiable toolbar. The only reason to add them redundantly into the hamburger menu would be to show keyboard shortcuts, but the menu does not do that. Also, we are working on a generic way to make keyboard shortcuts show up in button tooltips; see https://invent.kde.org/frameworks/kirigami/-/merge_requests/271.

So I would recommend removing the first four items in this menu.
Comment 1 Nate Graham 2021-05-04 16:55:45 UTC
I will send a MR soon.
Comment 2 Bug Janitor Service 2021-05-04 17:11:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/skanpage/-/merge_requests/6
Comment 3 Nate Graham 2021-05-04 19:38:31 UTC
Git commit dfc0389aa28ebeafea52f85b2f36ac0a2ddaf78b by Nate Graham.
Committed on 04/05/2021 at 19:38.
Pushed by ngraham into branch 'master'.

Remove redundant hamburger menu actions

The Scan, Save, Clear, and Configure actions are already visible in the
toolbar and cannot be removed. Hence, they are redundant in the
hamburger menu and can be removed with no loss of functionality or
accessibility.

M  +1    -17   src/MainWindow.qml

https://invent.kde.org/utilities/skanpage/commit/dfc0389aa28ebeafea52f85b2f36ac0a2ddaf78b