Bug 436587 - Not translatable strings in Settings --> Edit Geolocation
Summary: Not translatable strings in Settings --> Edit Geolocation
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-i18n (show other bugs)
Version: 7.3.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-04 14:47 UTC by herb
Modified: 2021-05-26 07:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.3.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description herb 2021-05-04 14:47:07 UTC
SUMMARY
Hello

Working on German translation I have seen that for Item --> Edit Geolocation
the following textstrings cannot be translated:
- for tab GPS Correlator: "Interpolate" and "Match directly"
- for tab Reverse Geocoding with right mouse: Add all address elements
  {House numer}
  {suburb}
  {city district}
  {state}
  {state district}
- for tab Undo/Redo: <empty>

They have no entry in digikam.po file (generated on 30.4.2021)

Please help
Thanks in advance
herb


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2021-05-04 15:55:32 UTC
A *.po file is created automatically, it is not edited manually.

Maik
Comment 2 Maik Qualmann 2021-05-04 15:56:17 UTC
*** This bug has been marked as a duplicate of bug 436532 ***
Comment 3 Maik Qualmann 2021-05-04 15:59:45 UTC
We are not responsible for missing translations. We only write the original English text in the source code. I think digiKam does not currently have a German maintaner for the translation. Other German translators have to take care of that and they have a lot to do ...

Maik
Comment 4 herb 2021-05-04 17:23:58 UTC
Hello Maik,

as far as I have seen, it is not a problem of missing translation (which I try to enhance), it is a problem that the English strings are missing in digikam.po file.

Best regards
herb
Comment 5 Maik Qualmann 2021-05-04 17:53:32 UTC
These {state district} tags etc are "commands", I don't think we will translate them. If you have a green result, you have a tooltip and can see which "command" it corresponds to.

Maik
Comment 6 herb 2021-05-04 20:06:53 UTC
Hello Maik,

thanks for your comments.
When we call right mouse "Add all address elements" a hierarchy of 12 "pseudo-tags" is created.
Most of them can be translated: e.g. {City} --> {Stadt} or {Country} --> {Land}
I agree that these a "placeholders" for ...

But the 5 elements listed by me cannot be translated, because there is no entry in digikam.po.
Why are 7 translatable and 5 not?

The goal is to have an identical behaviour for all.
Thanks in advance
herb
Comment 7 Maik Qualmann 2021-05-04 20:38:32 UTC
Git commit abda2bdfb411debb14eca44a1822dd0e6d602584 by Maik Qualmann.
Committed on 04/05/2021 at 20:37.
Pushed by mqualmann into branch 'master'.

add missing translation for the reverse geocoding
FIXED-IN: 7.3.0

M  +2    -1    NEWS
M  +7    -0    core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.cpp

https://invent.kde.org/graphics/digikam/commit/abda2bdfb411debb14eca44a1822dd0e6d602584
Comment 8 herb 2021-05-20 09:41:17 UTC
Hello Maik,

sorry to annoy you again.
But the string(s)

(1) {state} is still not translated inside a German GUI, although it has
    a translation in digikam.po file

(2) Interpolate and Match directly cannot be found in digikam.po
   (from 20.5.2021)

Best regards
herb
Comment 9 Maik Qualmann 2021-05-20 11:06:21 UTC
Hmm, the required translation "dummy" exists in the code.

https://invent.kde.org/graphics/digikam/-/blob/master/core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.cpp#L92

Maik
Comment 10 herb 2021-05-20 11:22:49 UTC
Hello Maik,

yes, you are right.
And also a translation of {State} into German is available in digikam.po/.mo file.
Nevertheless always the Englsh string is displayed.
Comment 11 Maik Qualmann 2021-05-20 11:42:57 UTC
Ok, maybe we won't apply the translation in the code. I'll check it out tonight.

Maik
Comment 12 Maik Qualmann 2021-05-20 20:30:37 UTC
Git commit d0d3ddc5617de63658abbba601c9e21d6fa76a36 by Maik Qualmann.
Committed on 20/05/2021 at 20:29.
Pushed by mqualmann into branch 'master'.

fix dummy translation if a context exists

M  +23   -2    core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.cpp

https://invent.kde.org/graphics/digikam/commit/d0d3ddc5617de63658abbba601c9e21d6fa76a36
Comment 13 Maik Qualmann 2021-05-20 20:36:10 UTC
I can see that the German translation is almost complete, I only see very few untranslated texts. Are you in contact with the Germin translator team?

Maik
Comment 14 Maik Qualmann 2021-05-21 04:29:13 UTC
Git commit 2606230a3356c8b2f59a32ec55e57e583993d5d7 by Maik Qualmann.
Committed on 21/05/2021 at 04:28.
Pushed by mqualmann into branch 'master'.

translate help tooltip from reverse geocoding

M  +27   -23   core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.cpp
M  +4    -0    core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.h

https://invent.kde.org/graphics/digikam/commit/2606230a3356c8b2f59a32ec55e57e583993d5d7
Comment 15 Maik Qualmann 2021-05-21 05:52:40 UTC
Git commit eee3d52e669ae43cec5f24ace264ac90c22d17ed by Maik Qualmann.
Committed on 21/05/2021 at 05:51.
Pushed by mqualmann into branch 'master'.

use translated text directly

M  +23   -26   core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.cpp

https://invent.kde.org/graphics/digikam/commit/eee3d52e669ae43cec5f24ace264ac90c22d17ed
Comment 16 herb 2021-05-25 11:27:34 UTC
Hello Maik,

Sorry for my late reply. You asked:
Are you in contact with the German translator team?

Yes, Burkhard Lück asked me to help "translating" digiKam; and I sayed: yes

Best regards
herb
Comment 17 Maik Qualmann 2021-05-25 11:55:37 UTC
Hi herb,

That's great!
Can you take a look at this translation, the spelling mistake had existed for a few years.

Metadata settings:

Fall möglich, Metadaten in RAW-Dateien schreiben (gefährlich)
^^^^

Maik
Comment 18 herb 2021-05-26 07:21:38 UTC
Hello Maik,

thanks for this hint.

Best regards
herb