Bug 436328 - there's no word "reconciliate" in English, should be reconcile
Summary: there's no word "reconciliate" in English, should be reconcile
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: Trunk from git
Platform: Flatpak Linux
: NOR minor
Target Milestone: ---
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-29 00:46 UTC by skierpage
Modified: 2021-04-30 11:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2021-04-29 00:46:13 UTC
SUMMARY
I got a happy message from Skrooge
   The account 'BigBankCo' has been reconciliated
but there's no such verb in English. The noun is reconciliation, the verb is reconcile (like action and act).

STEPS TO REPRODUCE
1. Successfully reconcile an account,
   or search for "[Rr]econciliate" in Skrooge source 

OBSERVED RESULT
The word reconciliate or reconciliated appears, on 35 lines in source.

EXPECTED RESULT
reconciliate -> reconcile ; reconciliated -> reconciled

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: 
KDE Frameworks Version: 5.81.0
Qt Version: 5.15.3 xcb

ADDITIONAL INFORMATION
I'll attempt a patch for this string in plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp. I'm not confident about changing the action strings edit_reconcilate, m_reconciliateAction, and I don't think other strings the UUID(?) skgoperationplugin_notreconciliated, the function onReconciliate, etc. appear in the UI.
Comment 1 Stephane MANKOWSKI 2021-04-30 11:20:41 UTC
Git commit 7d774f81fbcfaaab4c2202363355ee06744232c1 by Stephane MANKOWSKI.
Committed on 30/04/2021 at 11:20.
Pushed by smankowski into branch 'master'.

there's no word "reconciliate" in English, should be reconcile

M  +1    -0    CHANGELOG
M  +2    -2    plugins/skrooge/skrooge_bank/skgbankplugin.cpp
M  +1    -1    plugins/skrooge/skrooge_bank/skgbankplugin.h
M  +6    -6    plugins/skrooge/skrooge_operation/skgoperationplugin.cpp
M  +4    -4    plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp
M  +1    -1    plugins/skrooge/skrooge_scheduled/skgscheduledpluginwidget.cpp
M  +1    -1    tests/skgbankguitest/skgtestactions.cpp

https://invent.kde.org/office/skrooge/commit/7d774f81fbcfaaab4c2202363355ee06744232c1