Bug 436231 - OverlaySheet: incorrect extraMargin on applet configuration dialog
Summary: OverlaySheet: incorrect extraMargin on applet configuration dialog
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-04-26 19:05 UTC by Ismael Asensio
Modified: 2022-07-12 19:02 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.96
Sentry Crash Report:


Attachments
TimeZones OverlaySheet (95.76 KB, image/png)
2021-04-26 19:05 UTC, Ismael Asensio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ismael Asensio 2021-04-26 19:05:03 UTC
Created attachment 137935 [details]
TimeZones OverlaySheet

SUMMARY


When an overlay sheet is in istanciated in a configuration page of a Plasma' configuration dialog
Triaged this  bug into these lines https://invent.kde.org/frameworks/kirigami/-/blob/master/src/controls/templates/OverlaySheet.qml#L706-716

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATIONSUMMARY

The overlay sheet that is used in the Digital Clock configuration dialog sets the extraMargin property to a very high value (51px).

Acording to the comments in: https://invent.kde.org/frameworks/kirigami/-/blob/master/src/controls/templates/OverlaySheet.qml#L706-716
this should be reserved for mobile use cases. In the desktop it produces a really ugly result. 

I've found only this case and followed it up to these lines. It could be solved by setting the property to 0 in the client code, but maybe there is something wrong in the way we detect the mobile case.

STEPS TO REPRODUCE
1. Open the configuration for the Digital Clock in the plasma panel
2. Go to TimeZones
3. Click on 'Add TimeZones ...'
Comment 1 Nate Graham 2021-04-28 17:29:16 UTC
Heh I was just noticing this yesterday. :)
Comment 2 Ismael Asensio 2022-07-12 19:02:23 UTC
I forgot to link the MR to close this: https://invent.kde.org/frameworks/kirigami/-/merge_requests/569