Bug 436224 - file thumbnails not working
Summary: file thumbnails not working
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.4.3
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-26 17:07 UTC by Manga Tengu
Modified: 2021-05-27 19:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manga Tengu 2021-04-26 17:07:50 UTC
I'm sorry I don't remember exactly who I talked to on irc about this issue (maybe amyspark, I think I remember he changed something about files preview). It's been a while now thumbnails are broken in the finder. It makes life complicated when working on batches of 40 drawings.

STEPS TO REPRODUCE
1. Save a new drawing

OBSERVED RESULT
The preview should be replaced by a white page icon

EXPECTED RESULT
see a thumbnail of the file
Comment 1 vanyossi 2021-05-05 04:27:56 UTC
I can confirm this bug, quicklook generator does not create any preview.

this command on krita 3.3.3 generates a png preview, but on 4.4.0 and master creates a generic document icon, failing to produce a preview.

qlmanage -p <img.kra> -g krita.app/Contents/Library/QuickLook/kritaquicklook.qlgenerator -c image

probably it was broken by the changes on the generator by amyspark, should I assign them or may I take a look?
Comment 2 vanyossi 2021-05-06 16:15:10 UTC
Git commit b217aa9a8454fe6fab4899d86dc9c1d3fc97d981 by Ivan Yossi.
Committed on 06/05/2021 at 16:13.
Pushed by ivany into branch 'master'.

Fix quicklook generator

Removed HAVE_APPLE_COMPRESSION, we don't use this
to encode our zip files, setting this breaks data read.

M  +12   -1    krita/integration/README.md
M  +6    -5    krita/integration/integration.xcodeproj/project.pbxproj
M  +1    -1    krita/integration/quicklook/GeneratePreviewForURL.m

https://invent.kde.org/graphics/krita/commit/b217aa9a8454fe6fab4899d86dc9c1d3fc97d981
Comment 3 vanyossi 2021-05-17 07:16:15 UTC
Git commit 425a7bdfdb55f8e9c25a32c12fa8a2495f451215 by Ivan Yossi.
Committed on 17/05/2021 at 07:14.
Pushed by ivany into branch 'krita/4.3'.

Fix quicklook generator

Removed HAVE_APPLE_COMPRESSION, we don't use this
to encode our zip files, setting this breaks data read.

M  +12   -1    krita/integration/README.md
M  +6    -5    krita/integration/integration.xcodeproj/project.pbxproj
M  +1    -1    krita/integration/quicklook/GeneratePreviewForURL.m

https://invent.kde.org/graphics/krita/commit/425a7bdfdb55f8e9c25a32c12fa8a2495f451215
Comment 4 Manga Tengu 2021-05-24 14:09:44 UTC
Hello, on Krita Version: 4.4.4-alpha (git cc5d52c), and krita 5
I still have broken thumbnails.

I open any broken thumbnail file, do save and close but I still get a generic file icon.

Also before it was modified, thumbnails used to be previewed bigger than now (space bar in the finder on an element to preview it)
Comment 5 vanyossi 2021-05-27 02:34:49 UTC
please make sure 'qlmanage -m | grep kra' shows it is using the quicklook generator from the installed master/4.4.4-alpha. And also please regenerate caches so it forces the generator to recreate thumbnails.

qlmanage -r
and
qlmanage -r cached

The bug is solved
Comment 6 Manga Tengu 2021-05-27 07:37:03 UTC
I followed your instructions but the thumbnails didn't budge. I still have the same file icon :'(
Comment 7 vanyossi 2021-05-27 15:59:03 UTC
Hi, can you share your system OS version and specs? is the qlmanager commands I sent you show the quicklook generator used is from the latest install? (master/4.4.4-alpha)

When I was testing there was a version from my dev repos that did not produce any thumbnails, but the version packaged from jenkins, the 4.4.4-alpha does generate the proper thumbnails and fullsize preview (this build https://binary-factory.kde.org/job/Krita_Stable_MacOS_Build/)
Comment 8 Manga Tengu 2021-05-27 19:09:37 UTC
MacOS Big Sur
version 11.2.3 (20D91)
Macbook pro 15' 2018

It does work with the build you linked. I needed to open the "broken" files and save them again for the preview to be generated :o