Bug 436141 - Discover update section and update settings (in System Settings > System information > update) have the same icon
Summary: Discover update section and update settings (in System Settings > System info...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.21.4
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-04-24 20:23 UTC by Lua
Modified: 2021-04-28 15:58 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22


Attachments
kickoff entries (17.29 KB, image/png)
2021-04-24 20:23 UTC, Lua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lua 2021-04-24 20:23:04 UTC
Created attachment 137881 [details]
kickoff entries

SUMMARY


STEPS TO REPRODUCE
1. Search for "updates" in Kickoff.

OBSERVED RESULT
Currently, these two icons are identical and this can be confusing.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: Kubuntu 21.04
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Kernel Version: 5.11.0-16-generic
ADDITIONAL INFORMATION
Comment 1 Lua 2021-04-24 20:57:17 UTC
Changing to "Updates - Discover" to "Check for updates" is a solution too. It creates a better visual distinction.
Comment 2 Nate Graham 2021-04-27 17:51:45 UTC
Yeah. This "Updates - Discover" entry is apparently an application, according to KRunner (which shows items' categories). That seems like a bug. We should just remove it.

Aleix, do you know what's created this thing? I couldn't find it.
Comment 3 Aleix Pol 2021-04-27 23:59:09 UTC
It's the [Desktop Action Updates] within org.kde.discover.desktop.cmake.

It was created here, I guess we can also make the name more verbose.
https://phabricator.kde.org/D9637
Comment 4 Nate Graham 2021-04-28 00:08:35 UTC
Huh, I didn't realize that KRunner exposed jump list actions like this.

Yeah I guess we could make it say "Check for updates" or something.
Comment 5 Lua 2021-04-28 04:53:57 UTC
Or maybe "check for system updates" to make it more clearer, but it might not be accurate since Discover updates programs installed by the user.
Comment 6 Lua 2021-04-28 04:54:11 UTC
but might not be 100% accurate*
Comment 7 Bug Janitor Service 2021-04-28 15:09:38 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/118
Comment 8 Nate Graham 2021-04-28 15:58:59 UTC
Git commit acccd1cedd0c5bf9d1fd5416520ecd840f7e1777 by Nate Graham.
Committed on 28/04/2021 at 15:06.
Pushed by ngraham into branch 'master'.

Clarify "Updates" Jump List Action

This action suffers from unclear text because it does not start with an
action verb, and als its icon is identical to that of the new "Software
Update" KCM, causing the two to look nearly identical in search results.
Also these kinds of actions are supposed to be using monochrome icons
anyway.

This commit fixes those issues.
FIXED-IN: 5.22

M  +2    -2    discover/org.kde.discover.desktop.cmake

https://invent.kde.org/plasma/discover/commit/acccd1cedd0c5bf9d1fd5416520ecd840f7e1777