Bug 436045 - Dolphin user feedback falsely reports there are no samba shares in user places
Summary: Dolphin user feedback falsely reports there are no samba shares in user places
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 21.04.0
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-22 14:27 UTC by Dave
Modified: 2021-04-24 16:48 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave 2021-04-22 14:27:08 UTC
In my system I have a samba share in my Dolphin places panel. It was created by dragging and dropping a remote folder on the places panel. The entry path looks like this:

smb://user@server/path/to/folder

I was configuring Dolphin and decided to check what feedback was being sent and I noticed this:

   "places": {
        "hasNfsShare": false,
        "hasSSHFSMount": false,
        "hasSambaShare": false
    },

Which seems to be incorrect. Please correct me if I'm wrong. It is important to note that I didn't find the remote folder creator assistant from the network folder I used to use in the past so I didn't use it to create the samba share shortcut.

STEPS TO REPRODUCE
1. Check Dolphin's user feedback raw data

OBSERVED RESULT
This data is sent
> "hasSambaShare": false


EXPECTED RESULT
This data should be sent
> "hasSambaShare": true


SOFTWARE/OS VERSIONS
Debian Bullseye/testing
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.81.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-04-23 15:24:20 UTC
Mmmm. Will be a Dolphin-specific issue.
Comment 2 Méven Car 2021-04-24 05:06:02 UTC
Well in fact smb://user@server/path/to/folder is not a samba share in the sense dolphin expects it here.

It is not a fs mounted cifs filesystem and that what `hasSambaShare` means currently.

smb:// is a kio-extras io-slave that is a lot easier to handle than cifs mounts, that why the two kinds of samba share access are differentiated in the feedback.

Ref: https://invent.kde.org/system/dolphin/-/blob/master/src/userfeedback/placesdatasource.cpp
Comment 3 Nate Graham 2021-04-24 14:27:29 UTC
Is that actually what we want to measure though?
Comment 4 Méven Car 2021-04-24 16:48:24 UTC
> Is that actually what we want to measure though?

Elvis did this I doubt he meant otherwise.
If anything we could report which kio-slave are used.