Bug 435928 - When in button form, keep the button visible but disabled rather than hiding it when the focused app doesn't support global menus
Summary: When in button form, keep the button visible but disabled rather than hiding ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Menu (show other bugs)
Version: 5.21.4
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords: usability
Depends on: 374996
Blocks:
  Show dependency treegraph
 
Reported: 2021-04-19 17:40 UTC by John
Modified: 2024-03-22 09:48 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.3


Attachments
Switching Software effect (43.93 KB, video/webm)
2024-03-15 16:38 UTC, John
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John 2021-04-19 17:40:08 UTC
SUMMARY
When in it's single-button form it would be very nice that the Global Menu would  have an option to "always show the menu" (even if there’s no app using it)!

When one has the Global Menu button on a panel (with other widgets placed after it) it constantly shows and hides when one alternates between apps that support it (Kate) and those that doesn't (firefox) or when we close apps. This constant show/hide affects all the other widgets placed after it that have to adjust to the space left.

STEPS TO REPRODUCE
1. Place the Global Menu on a panel
2. Set it to show as a single button
3. place other widgets after it
4. open Kate
5. open firefox
6. alternate between the two apps

OBSERVED RESULT
Global menu shows when kate is selected and hides when we select firefox
all the other widgets placed after the global menu button  rearrange themselves to the space left

EXPECTED RESULT
the other widgets should be in a fixed position


possibly related to:
https://bugs.kde.org/show_bug.cgi?id=374996
Comment 1 John 2022-07-02 12:34:10 UTC
(In reply to John from comment #0)
> When in it's single-button form it would be very nice that the Global Menu
> would  have an option to "always show the menu"

I was thinking about this and instead of an option to "always show the menu" the option should be "preserve the menu space when inactive" or something along this lines.

Maybe the menu could be shown in a gray (not active) look or invisible (opacity=0)
Comment 2 John 2022-10-20 17:08:06 UTC
Latest Frameworks (5.99) apparently seem to behave like this:
If global menu is in its "Extended" Menu form (not button) it hides and shows according to the Application
If Global menu is in its Button form It's always shown - faded if there is no menu entries, Active if the application has menus to be shown

This seems logic to me but:

I think this is a bug because it works like this when plasma starts but if we change to "extended" form and then back to the button form it no longer has this behavior.

 can someone confirm it's a bug or a feature?

(hope i was not too confusing!)
Comment 3 Nate Graham 2022-10-21 16:11:29 UTC
That's not a bad idea.
Comment 4 John 2022-10-22 15:03:43 UTC
(In reply to Nate Graham from comment #3)
> That's not a bad idea.

No, it's not!

I just don't know if this was intentional or not. But for me it makes perfect sense.

But, if we're taking this path we need to fix that *bug. If we choose the extended mode and then go to button mode we loose this behavior (me ao always visible single button) and I don't really know how I got it back working as I intended!

Still, for me, this behaviour would be great!

(by the way, Nate... A side note: Krita is not working with Global Menu... )
Comment 5 ratijas 2022-10-23 14:15:21 UTC
> (by the way, Nate... A side note: Krita is not working with Global Menu... )

I don't know why you directed that comment specifically to Nate, but Krita indeed does not work with neither Global Menu nor KDecorations menu button, so it's a bug in Krita and should be reported to them.
Comment 6 John 2022-10-24 12:02:53 UTC
(In reply to ratijas from comment #5)

> I don't know why you directed that comment specifically to Nate,

You're right. I apologize for that! 

It's just because he's the only person that has made any comment in this bug.

but yeah, you're right! I shouldn't have made it directly to him and i should have gone report the bug directly... 
... if only i had the time for searching duplicates - with all the possible words - and then fill in a "decent" bug report in case i didn't find any - which i didn't! (most of the times he already have this kind of bugs on a following list)

but i apologize everyone, anyway.
Comment 7 John 2024-01-04 12:16:51 UTC
I can't replicate what i mentioned in Comment 2 anymore (which, to me, is a big drawback!)

Is anyone aware of any kind of workaround, any config i may add or anything?

Thanks in advance
Comment 8 John 2024-03-13 12:54:05 UTC
Apparently this commit:

https://invent.kde.org/plasma/plasma-workspace/-/commit/5937f917b29388e849341c8f1ef03f3bfeba4456

removed the possibility of keeping the space used by the menu
Comment 9 John 2024-03-15 16:38:01 UTC
Created attachment 167275 [details]
Switching Software effect

Switching between software that supports Global Menus and those that don't.
Comment 10 Bug Janitor Service 2024-03-18 21:32:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4102
Comment 11 Nate Graham 2024-03-22 04:35:14 UTC
Git commit 3bfeffbd1a087a4ff6ff0c1d5d051dcce7e54e52 by Nate Graham.
Committed on 22/03/2024 at 04:23.
Pushed by ngraham into branch 'master'.

applets/appmenu: fix keeping button always visible in compact mode

In compact mode, the button tries to disable itself rather than hiding
when the active app doesn't support the global menu, but this gets
undone by the widget setting itself to hidden when in that state.

We can minimally fix this by adding an extra condition to the status
property code.
FIXED-IN: 6.0.3

M  +1    -2    applets/appmenu/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/3bfeffbd1a087a4ff6ff0c1d5d051dcce7e54e52
Comment 12 Nate Graham 2024-03-22 04:59:00 UTC
Git commit 94ef9514cc1cdaf568ae7aebd16716dcb78741f6 by Nate Graham.
Committed on 22/03/2024 at 04:42.
Pushed by ngraham into branch 'Plasma/6.0'.

applets/appmenu: fix keeping button always visible in compact mode

In compact mode, the button tries to disable itself rather than hiding
when the active app doesn't support the global menu, but this gets
undone by the widget setting itself to hidden when in that state.

We can minimally fix this by adding an extra condition to the status
property code.
FIXED-IN: 6.0.3


(cherry picked from commit 3bfeffbd1a087a4ff6ff0c1d5d051dcce7e54e52)

M  +1    -2    applets/appmenu/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/94ef9514cc1cdaf568ae7aebd16716dcb78741f6
Comment 13 John 2024-03-22 09:48:42 UTC
(In reply to Nate Graham from comment #12)
> Git commit 94ef9514cc1cdaf568ae7aebd16716dcb78741f6 by Nate Graham.
> Committed on 22/03/2024 at 04:42.
> Pushed by ngraham into branch 'Plasma/6.0'.
> 
> applets/appmenu: fix keeping button always visible in compact mode
> 
> We can minimally fix this by adding an extra condition to the status
> property code.
> FIXED-IN: 6.0.3

Wonderful!!! Thank you!!! :D