Bug 435890 - With "show Percentage" setting in use, an empty overlay is displayed when no batteries are connected
Summary: With "show Percentage" setting in use, an empty overlay is displayed when no ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Battery Monitor (show other bugs)
Version: 5.21.4
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-18 21:17 UTC by medin
Modified: 2021-04-23 04:38 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/b88713cbbf31f676d7b3da93de27d7ab70a5e302
Version Fixed In: 5.22

Attachments
Brightness icon looks inconsistent with no battery connected (7.35 KB, image/png)
2021-04-18 21:17 UTC, medin 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2021-04-18 21:17:56 UTC 
Created attachment 137693 [details]
Brightness icon looks inconsistent with no battery connected

In tray system, if you set "Show percentage" in brightness widget settings with no  battery connected then the brightness icon becomes inconsistent. See attached image for more info.

Operating System: Manjaro Linux
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.81.0
Qt Version: 5.15.2
Kernel Version: 5.4.112-1-MANJARO
OS Type: 64-bit
Graphics Platform: X11
Comment 1 Bug Janitor Service 2021-04-21 20:34:40 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/806
Comment 2 Nate Graham 2021-04-23 04:38:33 UTC 
Git commit b88713cbbf31f676d7b3da93de27d7ab70a5e302 by Nate Graham.
Committed on 23/04/2021 at 04:37.
Pushed by ngraham into branch 'master'.

[applets/batterymonitor] Don't show percentage overlay with no batteries

There's no point, since it always says "-" and just covers up the icon.
Let's only show the overlay if there are actually any batteries.
FIXED-IN: 5.22

M  +2    -2    applets/batterymonitor/package/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b88713cbbf31f676d7b3da93de27d7ab70a5e302