Bug 435714 - Provide Dark/Light theme color palette options
Summary: Provide Dark/Light theme color palette options
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-14 06:01 UTC by PK
Modified: 2021-04-14 08:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
"colors" drop-down (756.52 KB, image/jpeg)
2021-04-14 06:01 UTC, PK
Details

Note You need to log in before you can comment on or make changes to this bug.
Description PK 2021-04-14 06:01:19 UTC
Created attachment 137576 [details]
"colors" drop-down

SUMMARY
Suggestion to give the opportunity to link a latte-panel to a certain installed plasma-theme to give it a permanent color.

STEPS TO REPRODUCE
1. Right-click on latte-panel
2. choose the second tab from the left in extended view (how the panel looks)
3. then go to colors.

OBSERVED RESULT

In the "colors" drop-down there is a choice between "Plasma", "Reverse" and "Smart". (attachment)

EXPECTED RESULT

Wouldn't it be nice if the word "Plasma" was replaced with "Current Plasma" (or so) and that the other installed plasma-themes also appeared in this drop-down so that you could choose this panel to always be dark or light e.g.


SOFTWARE/OS VERSIONS

Operating System: KDE neon 5.21
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.81.0
Qt Version: 5.15.2
Kernel Version: 5.10.8-051008-generic
OS Type: 64-bit
Graphics Platform: X11
Processors: 4 × Intel® Celeron® J4105 CPU @ 1.50GHz
Memory: 7.4 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 600

ADDITIONAL INFORMATION
Comment 1 Michail Vourlakos 2021-04-14 06:17:25 UTC
Just choosing colors is not that simple in order to not break uniformity. The current options give you the possibility for something to be always dark or white. 

So the question is what youbare trying to achieve that it is not already possible?
Comment 2 PK 2021-04-14 06:25:07 UTC
Oh, that could be my bad. But would the color of the panel hold even if you started using an other plasma theme or desktop-wallpaper?
Comment 3 PK 2021-04-14 06:31:28 UTC
Oh, I think I see what you mean... But then perhaps uniformity wouldn't be broken if you added the choice "Dark" and "Light" next to "Plasma, Reverse and Smart"...
Comment 4 Michail Vourlakos 2021-04-14 06:39:56 UTC
Hm, I have to think it. There was that proposal in the past but I cant remember what was the main objection.
Comment 5 PK 2021-04-14 06:51:47 UTC
Thank you! Example: I sometimes use a self-made latte-layout that mimics Gnome (3). It would be nice to have the opportunity to make the top-bar always black...
Comment 6 Michail Vourlakos 2021-04-14 06:56:01 UTC
(In reply to PK from comment #5)
> Thank you! Example: I sometimes use a self-made latte-layout that mimics
> Gnome (3). It would be nice to have the opportunity to make the top-bar
> always black...

Isnt this already the case by choosing Reverse colors?
Comment 7 Michail Vourlakos 2021-04-14 07:16:03 UTC
My second thoughts is that from layout designers point of view, Light, Dark might be necessary. 

When Latte layouts are published in public the designer does not know what plasma theme the user is using in its system. 

Having Light, Dark options it guarantees that the user will have a dark or light experience always. 

It falls to layout designers to disable autocoloring for applets that should not use autocoloring at all.
Comment 8 Michail Vourlakos 2021-04-14 07:48:18 UTC
Git commit 8d0c26a2e145fb573d0b8d72c85221b91f59a084 by Michail Vourlakos.
Committed on 14/04/2021 at 07:44.
Pushed by mvourlakos into branch 'master'.

provide Dark/Light Colors options

--this way a layout designer can force to its users
the desired color palette for each dock and panel.

BeCareful: designers should be very careful with this
because they take responsibility to disable latte auto-coloring
at per-applet basis in order for chromatic applets to NOT
be autocolored from latte because they already provide enough
contrast.

M  +2    -0    containment/package/contents/config/main.xml
M  +5    -1    containment/package/contents/ui/colorizer/Manager.qml
M  +3    -1    containment/plugin/types.h
M  +41   -11   shell/package/contents/configuration/pages/AppearanceConfig.qml

https://invent.kde.org/plasma/latte-dock/commit/8d0c26a2e145fb573d0b8d72c85221b91f59a084
Comment 9 Michail Vourlakos 2021-04-14 07:48:58 UTC
enjoy...
Comment 10 PK 2021-04-14 08:33:33 UTC
Really great!