Bug 435694 - Windows in thumbnails blend into tooltip background when plasma theme follows system color scheme
Summary: Windows in thumbnails blend into tooltip background when plasma theme follows...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.21.3
Platform: Manjaro Linux
: NOR minor
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-13 14:50 UTC by Michael D
Modified: 2021-04-20 19:17 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22
Sentry Crash Report:


Attachments
Shadow drawn around firefox window, but not dolphin window which blends into tooltip (121.31 KB, image/png)
2021-04-13 14:50 UTC, Michael D
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2021-04-13 14:50:52 UTC
Created attachment 137565 [details]
Shadow drawn around firefox window, but not dolphin window which blends into tooltip

When using the breeze plasma theme which inherits the window background color for tooltips, windows blend into the background of the task manager tooltip. It would look better if the shadow or a border were drawn around the window. I noticed the shadow is drawn for firefox (at least with titlebar disabled) which makes the tooltip look much better.
Comment 1 Bug Janitor Service 2021-04-13 23:46:10 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/423
Comment 2 Nate Graham 2021-04-20 18:33:14 UTC
Git commit 28b79d4c6d6c9b9c7ec6a22de3a427aa6276495c by Nate Graham.
Committed on 20/04/2021 at 18:32.
Pushed by ngraham into branch 'master'.

[applets/taskmanager] Add drop shadow behind tooltip window thumbnails

This adds a bit of visual bling and also helps to visually distinguish
the window thumbnail from its background, in cases where they might be
similar (which can happen given the diversity of possible combinations
of Plasma themes and window appearances).
FIXED-IN: 5.22

M  +20   -3    applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://invent.kde.org/plasma/plasma-desktop/commit/28b79d4c6d6c9b9c7ec6a22de3a427aa6276495c
Comment 3 Michael D 2021-04-20 19:05:49 UTC
This looks great. Thanks!
Comment 4 Nate Graham 2021-04-20 19:17:46 UTC
You're welcome!