Bug 435466 - kpat Windows build fails in binary-factory
Summary: kpat Windows build fails in binary-factory
Status: RESOLVED FIXED
Alias: None
Product: kpat
Classification: Applications
Component: general (show other bugs)
Version: 21.03.80
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-07 13:58 UTC by Evren
Modified: 2021-04-21 21:34 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evren 2021-04-07 13:58:03 UTC
Game does not launch and give error message "libfreecell-solver.dll cannot be found", this file is not exist in application folder, neither in windows system
Comment 1 Albert Astals Cid 2021-04-07 17:30:51 UTC
Where did you even get kpat installed in windows?
Comment 2 Evren 2021-04-13 08:09:14 UTC
I have downloaded kpat from this link:
https://binary-factory.kde.org/view/Windows%20MingW/job/KPat_Nightly_mingw64/

It seems latest nightly builds are failing, last successful build is from last year, so i downloaded that, externally searching libfreecell-solver.dll on the internet and downloading it solves dependency, so it should be included inside package
Comment 3 Albert Astals Cid 2021-04-14 20:22:25 UTC
Well, the first thing that should happen is that it should build :D
Comment 4 Jazeix Johnny 2021-04-14 20:33:10 UTC
Fails since defaulting the use of black-hole solver (https://invent.kde.org/games/kpat/-/commit/e9ceec479c482642b9d19209f4343a18d2309680) to ON.

Setting it to OFF in https://invent.kde.org/packaging/craft-blueprints-kde/-/blob/master/kde/kdegames/kpat/kpat.py should, at least, remove the actual error. We can also look at packaging the BH solver but it seems to require python libraries and perl (https://github.com/shlomif/black-hole-solitaire/blob/master/.appveyor.yml) and I don't know how much is handled by Craft.

Settings the option is done like that: https://invent.kde.org/packaging/craft-blueprints-kde/-/blob/master/kde/applications/marble/marble.py#L27

Are you interested trying to submit a Merge Request for it?
Comment 5 Bug Janitor Service 2021-04-17 16:09:23 UTC
A possibly relevant merge request was started @ https://invent.kde.org/packaging/craft-blueprints-kde/-/merge_requests/127
Comment 6 Albert Astals Cid 2021-04-17 16:20:34 UTC
Git commit 82fecd4f56d6f206a9eec61f797812d4afecbcd2 by Albert Astals Cid.
Committed on 17/04/2021 at 16:20.
Pushed by aacid into branch 'master'.

kpat: fix package

libfreecell-solver is a runtime dep (i.e. it has a dll we need) not only
a buildtime dep

M  +1    -1    kde/kdegames/kpat/kpat.py

https://invent.kde.org/packaging/craft-blueprints-kde/commit/82fecd4f56d6f206a9eec61f797812d4afecbcd2
Comment 7 Evren 2021-04-21 21:02:04 UTC
this bug might be fixed but kpat latest successful build is 9 months old, it is failed to build since then, so i am unable to test it currently
Comment 8 Albert Astals Cid 2021-04-21 21:34:00 UTC
The whole KDE on windows build infrastructure is broken at the moment, not much to do than sit and way for the people working on fix it to finish their work.

Nothing kpat specific.