Bug 435443 - Discover "re-enters" app page when changing sources
Summary: Discover "re-enters" app page when changing sources
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: 5.21.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-06 23:24 UTC by Felipe Kinoshita
Modified: 2021-04-07 11:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22
Sentry Crash Report:


Attachments
observed result (367.84 KB, video/webm)
2021-04-06 23:24 UTC, Felipe Kinoshita
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Felipe Kinoshita 2021-04-06 23:24:22 UTC
Created attachment 137392 [details]
observed result

When changing sources (e.g from openSUSE RPM's to Flatpaks) Discover will start the same animation as it was the first time entering in an app page.

STEPS TO REPRODUCE
1. Enter in some app page (e.g Krita)
2. Change sources (e.g from openSUSE RPM's to Flatpaks)

OBSERVED RESULT
Same animation is triggered which is kinda confusing.

EXPECTED RESULT
Discover should not start any animation when changing sources.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed
(available in About System)
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.81
Qt Version: 5.15.2
Comment 1 Bug Janitor Service 2021-04-07 01:29:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/103
Comment 2 Aleix Pol 2021-04-07 11:29:05 UTC
Git commit 1d1911152d2c0f544d0fa3d695e9a7aa03f7c83b by Aleix Pol.
Committed on 07/04/2021 at 01:17.
Pushed by ngraham into branch 'master'.

Remove the animation when changing app sources

It only replaces the contents on the page. Initially, I thought it would
look odd, but it's reasonably clean and seems to just work.

M  +1    -4    discover/qml/ApplicationPage.qml

https://invent.kde.org/plasma/discover/commit/1d1911152d2c0f544d0fa3d695e9a7aa03f7c83b