Bug 435303 - Digikam crashes when selecting 2 times Item opening Web Window in Help menu
Summary: Digikam crashes when selecting 2 times Item opening Web Window in Help menu
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Runtime (show other bugs)
Version: 7.2.0
Platform: Appimage Linux
: NOR crash
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-03 09:24 UTC by Nicofo
Modified: 2022-01-23 14:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.3.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicofo 2021-04-03 09:24:34 UTC
SUMMARY
1. In Digikam, go to Help menu and select either
- Donate
- Recipes Book
- Contribute
- Online Handbook

>> Result: a window opens with the requested web page

2. Close that window and repeat step 1

>> Result: digikam crashes

XIO:  fatal IO error 0 (Success) on X server ":0"
      after 3465 requests (3465 known processed) with 7 events remaining.
/tmp/.mount_digiKajL6bqD/AppRun: line 172:  6723 Segmentation fault      (core dumped) digikam $@

If you cannot reproduce the problem, I'll download digikam with debug.

NOTE
Happens with Appimage 7.2 and 7.1
No problem with Fedora RPM 7.1
Comment 1 Maik Qualmann 2021-04-03 10:22:00 UTC
The problem cannot be reproduced here, you are welcome to create a GDB backtrace. The cause is definitely QWebEngine. QWebEngine is very dependent on the OpenGL hardware it supports. QWebEngine is the future, a return to QWebKit is not responsible for security reasons.

Maik
Comment 2 caulier.gilles 2021-04-03 11:09:57 UTC
All of this action open a embedded version of web browser based on Chromium Qt (QtWebEngine). I suspect an incompatibility with your video card (opengl).

Gilles Caulier
Comment 3 caulier.gilles 2021-04-03 12:29:12 UTC
You said 2 times opening item menu ? For ex, you open Help/Donate, the web page is show, you don't close it, and you re-try Help/donate, and in this case you got a crash ?

If yes, the problem is a little bit different.

Gilles Caulier
Comment 4 Nicofo 2021-04-03 14:24:15 UTC
(In reply to caulier.gilles from comment #3)
> You said 2 times opening item menu ? For ex, you open Help/Donate, the web
> page is show, you don't close it, and you re-try Help/donate, and in this
> case you got a crash ?
> 
> If yes, the problem is a little bit different.
> 
> Gilles Caulier

No:
1. Help/Donate, the web page is shown
2. I close the web page
3. Again Help/Donate (or Help/<other>) -> crash

Note: If I don't close the web page and open it a second time, no crash (i.e. I have 2 web pages open)

I use the proprietary nvidia drivers. But no problem with Fedora RPM (version 7.1; in "Components Information" > Qt WebEngineSupport: Yes). So I suspect a problem with appimage bundle ?

OK I'll use debug appimage version and give you the trace later.
Comment 5 Maik Qualmann 2021-04-03 14:50:00 UTC
Git commit 365aacda04047ba38cafcdfd05d84d9994249f22 by Maik Qualmann.
Committed on 03/04/2021 at 14:49.
Pushed by mqualmann into branch 'master'.

delete WebBrowserDlg when close

M  +2    -0    core/libs/dialogs/webbrowserdlg.cpp

https://invent.kde.org/graphics/digikam/commit/365aacda04047ba38cafcdfd05d84d9994249f22
Comment 6 Nicofo 2021-04-04 18:58:35 UTC
(In reply to Maik Qualmann from comment #5)
> Git commit 365aacda04047ba38cafcdfd05d84d9994249f22 by Maik Qualmann.
> Committed on 03/04/2021 at 14:49.
> Pushed by mqualmann into branch 'master'.
> 
> delete WebBrowserDlg when close
> 
> M  +2    -0    core/libs/dialogs/webbrowserdlg.cpp
> 
> https://invent.kde.org/graphics/digikam/commit/
> 365aacda04047ba38cafcdfd05d84d9994249f22

Thank you Maik !
I have just tested with last appimage (digiKam-7.3.0-20210404T082005-x86-64): no more crash !

Note: previously, it crashes every time a web page was opened a second time (not only from Help menu, but also e.g. for login to Onedrive, ...). So your correction will probably prevent a lot of "strange" crashes :-) Strange because it was only the second time it crashed and therefore not always reproducible.
Comment 7 Maik Qualmann 2021-04-04 19:16:30 UTC
Thanks for the feedback.

Maik