Bug 435293 - color history popup shouldn't appear centered
Summary: color history popup shouldn't appear centered
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 4.4.3
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 436311 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-04-03 06:13 UTC by Manga Tengu
Modified: 2022-10-11 07:53 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manga Tengu 2021-04-03 06:13:47 UTC
This is very opinionated: I'm pretty sure most people opening the color history popup are only interested in the latest color used. 

But the popup appears centered so generally, I need to move the cursor up (toward) to the color targeted without the cursor getting out of the popup's thin column (or it will disappear). Yes I know, we can make more columns and widen them, but we shouldn't need to have to. This ends up like a dexterity game where one needs to stay inside the popup to reach the color needed or it will disappear. I'm pretty sure I'm not the only one getting frustrated at the color popup disappearing while trying to click a color.
Comment 1 Manga Tengu 2021-04-03 06:14:34 UTC
So I think a workaround would be to center the popup on the latest color used rather than the middle of the popup.
Comment 2 Tiar 2021-04-28 15:01:37 UTC
*** Bug 436311 has been marked as a duplicate of this bug. ***
Comment 3 Manga Tengu 2021-04-28 15:04:16 UTC
arf sorry
Comment 4 Tiar 2021-04-28 15:55:54 UTC
I added it as an item on https://krita-artists.org/t/beginner-coding-tasks-in-krita-easy-and-short-feature-requests-ready-to-implement/5851 so there is a higher chance it will be picked by a volunteer, since it seems to be a very simple task.
Comment 5 Manga Tengu 2021-04-28 15:57:30 UTC
thank you <3 !
Comment 6 Emmet O'Neill 2021-11-25 06:03:08 UTC
To add more information, the "color history popup" is a GUI element that can be summoned by a keyboard shortcut action. (The default keybinding is `H`.)

I had no idea that this thing even existed, and you're right Manga Tengu, it's not the best UX.
Comment 7 Emmet O'Neill 2021-11-25 06:34:49 UTC
SySagar and I were able to confirm that this issue, so I've marked this as confirmed.

Sy would like to take a crack at improving this, too.
Comment 8 halfspike 2022-06-05 13:27:44 UTC
Looks like widgets are centered by default in libs/flake/KoCanvasController.cpp via referredCenterFractionX(0.5)?

(A similar thing is happening with the vertical "used colors" popup, shortcut U, but in that use case it's probably fine.)
Comment 9 halfspike 2022-06-05 13:52:10 UTC
(In reply to halfspike from comment #8)
> Looks like widgets are centered by default in
> libs/flake/KoCanvasController.cpp via referredCenterFractionX(0.5)?
> 
> (A similar thing is happening with the vertical "used colors" popup,
> shortcut U, but in that use case it's probably fine.)

Oh, that was something else.
This is in plugins/dockers/advancedcolorselector/kis_color_selector_base.cpp
Comment 10 halfspike 2022-08-08 11:06:38 UTC
Turns out the popup uses the same settings as the color picker docker, which supports many different sizes and layouts. 

Perhaps the smoothest fix to this issues is to add a new action to directly switch to the previously used color (this does come very close to just switching between foreground/background colors though), and for the ui issue just increase the default size of the colored swatch?
Comment 11 Manga Tengu 2022-08-08 13:02:44 UTC
Then I would rather make it stackable like: 

"Previous until I find back the color I wanted. 
Ah I made an extra previous
no problem I can next back forward one step"

This is desirable in situations like "dang I used that popping red a few colors ago...back back back.. oh there"

Thant would be cool and clearly distinct from background/foreground.