Bug 435292 - Improve description for "Keep above" tool tip
Summary: Improve description for "Keep above" tool tip
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-03 01:54 UTC by Matthias
Modified: 2021-04-06 13:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.22
Sentry Crash Report:


Attachments
Keep above (5.18 KB, image/png)
2021-04-03 01:55 UTC, Matthias
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias 2021-04-03 01:54:28 UTC
SUMMARY

The more experienced KDE users probably understand, what the tooltip 'Keep above' is meant for. Still, even for seasoned users, this sounds a little bit too generalized. The tooltip, that appears when you hover over the title bar button, that keeps windows over the others, is sparse, and can lead to additional confusion, since it can be read in activated state, and then suggests doing the opposite of what it truly does. 

Let`s improve this. 

STEPS TO REPRODUCE
1. Add a "keep above" title button to the title bar. 
2. Hover over the button. 
3. Activate it, and hover again over the button, assuming you are a user, who is just figuring out, what this button does. 

OBSERVED RESULT

Confusion

EXPECTED RESULT

Clarity

ADDITIONAL INFORMATION

Operating System: KaOS (2021)
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2

SUGGESTION

I suggest the following sentence as a replacement for the current one's;

Keep this window always above others.
Do not keep this window above others.
Comment 1 Matthias 2021-04-03 01:55:13 UTC
Created attachment 137289 [details]
Keep above
Comment 2 Bug Janitor Service 2021-04-06 02:44:34 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdecoration/-/merge_requests/7
Comment 3 Nate Graham 2021-04-06 13:33:15 UTC
Git commit 1a4b8b89667b229290bbc167fd46d22b210c3b39 by Nate Graham.
Committed on 06/04/2021 at 02:42.
Pushed by ngraham into branch 'master'.

Improve tooltips for "keep above"/"keep below" buttons

It may not be totally clear what exactly they're being kept above.
FIXED-IN: 5.22

M  +4    -4    src/decorationbutton.cpp

https://invent.kde.org/plasma/kdecoration/commit/1a4b8b89667b229290bbc167fd46d22b210c3b39
Comment 4 Nate Graham 2021-04-06 13:33:35 UTC
Git commit dd3f85d19a2e7c1c419f8c4d5b031c48456dc0bb by Nate Graham.
Committed on 06/04/2021 at 13:33.
Pushed by ngraham into branch 'master'.

Improve text for "keep above"/"keep below" buttons

It may not be totally clear what exactly they're being kept above.

M  +2    -2    src/kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp
M  +2    -2    src/kcmkwin/kwinrules/rulesmodel.cpp

https://invent.kde.org/plasma/kwin/commit/dd3f85d19a2e7c1c419f8c4d5b031c48456dc0bb