Bug 435193 - crop redo causes crash
Summary: crop redo causes crash
Status: RESOLVED DUPLICATE of bug 433770
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: 4.4.3
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-31 17:05 UTC by Halcyoen
Modified: 2021-04-01 16:00 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Halcyoen 2021-03-31 17:05:29 UTC
SUMMARY
trying to crop a picture a more than once and then pressing 'redo' before before fully applying the last crop will cause krita to crash. 

STEPS TO REPRODUCE
1. create a new document
2. crop the canvas to a new size and apply. krita adds an entry to the undo history.
3. start cropping the canvas again (without applying) and see krita moves back one step in the undo history.
4. press 'redo' while the crop is still active.

EXPECTED RESULT
krita probably shouldnt be moving back one step in the undo history as soon as you start cropping the canvas. hitting undo or redo while in the middle of cropping should probably just cancel the crop action and return to the step in the undo history where the crop was started. 

SOFTWARE/OS VERSIONS
Windows 10
Comment 1 tomtomtomreportingin 2021-03-31 21:45:27 UTC
I'm not seeing the same things you see with these steps... are you sure you weren't triggering https://bugs.kde.org/show_bug.cgi?id=433770 , which is already fixed for upcoming releases?
Comment 2 Ahab Greybeard 2021-04-01 08:02:25 UTC
With the 4.4.3 appimage, I could reproduce this just once and that was associated with the undo history moving back one step, as noted in the Description.
After that, I never saw the undo history move back.

I can induce a crash every time in 4.4.3 for the conditions as noted for https://bugs.kde.org/show_bug.cgi?id=433770 but this has been fixed for the nightly builds.

@ Halcyoen
Can you reproduce this in 4.4.3 with the undo history moving back or in the nightly builds?
Comment 3 Halcyoen 2021-04-01 16:00:19 UTC
oh i guess youre right. i downloaded the nightly and i cant reproduce the crash there. i can reproduce it consistently in 4.4.3 but not in the nightly build. the nightly had an issue with the enter key not working to apply a crop but thats probably just some dev build jankiness.

looks like it was either the same as or related to the bug tomtomtomreportingin and ahab has linked to which was patched for krita 5. case closed! :)

*** This bug has been marked as a duplicate of bug 433770 ***