Bug 435173 - undelete tor-browse app icon?
Summary: undelete tor-browse app icon?
Status: RESOLVED DOWNSTREAM
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (other bugs)
Version First Reported In: 5.21.3
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-31 08:36 UTC by Sadi
Modified: 2021-03-31 14:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sadi 2021-03-31 08:36:09 UTC
I've just noticed that tor-browser icon has been deleted 2 months ago, because "the upstream icon is actually quite Breeze-like now. So our Breeze-style
variant does not seem to be needed."
But when I select breeze icon theme, no icon is displayed for Tor Browser now.
I don't know what is meant by "upstream" here.
It can't be gnome or hicolor icons - and they don't have that icon anyway.
Comment 1 2wxsy58236r3 2021-03-31 11:21:23 UTC
The upstream icon can be found in the Tor Browser download archive [1] (tor-browser_en-US/Browser/browser/chrome/icons/default/).
You can also view the icon here. [2]

For Arch Linux, the AUR package installs the icon to /usr/share/pixmaps/. [3]

[1] https://www.torproject.org/dist/torbrowser/10.0.15/tor-browser-linux64-10.0.15_en-US.tar.xz
[2] https://commons.wikimedia.org/wiki/File:Tor_Browser_icon.svg
[3] https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=tor-browser
Comment 2 Sadi 2021-03-31 12:49:45 UTC
(In reply to 2wxsy58236r3 from comment #1)

Thanks! Now I understand what "upstream" means in this case.
I've now copied that icon to my local folder ~/.local/share/icons/breeze" and it looks great. I don't know if this is a better way. ;-)
Comment 3 Nate Graham 2021-03-31 14:10:04 UTC
"upstream icons" means the icon from the app itself. If the app doesn't install any icon at all, that would be a bug in the app pr its packaging for your distro. Apps shouldn't rely  on any particular icon theme being installed on the user's system.