Bug 435069 - Commit 250feee0cac866730ef305aec4c0670d92cba34d breaks kwayland compilation
Summary: Commit 250feee0cac866730ef305aec4c0670d92cba34d breaks kwayland compilation
Status: RESOLVED NOT A BUG
Alias: None
Product: kwayland
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Martin Flöser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-28 15:25 UTC by Eugene Shalygin
Modified: 2021-03-28 22:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Shalygin 2021-03-28 15:25:31 UTC
SUMMARY
Does not compile against wayland-protocols 1.2.0 and git master. Reverting the said commit makes it compile. 5.80.0 builds too.

STEPS TO REPRODUCE
1. mkdir -p build & cd build & cmake ..
2. make


OBSERVED RESULT

src/client/plasmawindowmanagement.cpp:425:1: error: too many initializers for ‘org_kde_plasma_window_listener’
  425 | };
      | ^
src/client/plasmawindowmanagement.cpp: In member function ‘void KWayland::Client::PlasmaWindow::requestEnterActivity(const QString&)’:
src/client/plasmawindowmanagement.cpp:1185:5: error: ‘org_kde_plasma_window_request_enter_activity’ was not declared in this scope; did you mean ‘org_kde_plasma_window_request_resize’?
 1185 |     org_kde_plasma_window_request_enter_activity(d->window, id.toUtf8());
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     org_kde_plasma_window_request_resize
src/client/plasmawindowmanagement.cpp: In member function ‘void KWayland::Client::PlasmaWindow::requestLeaveActivity(const QString&)’:
src/client/plasmawindowmanagement.cpp:1190:5: error: ‘org_kde_plasma_window_request_leave_activity’ was not declared in this scope; did you mean ‘org_kde_plasma_window_request_resize’?
 1190 |     org_kde_plasma_window_request_leave_activity(d->window, id.toUtf8());
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     org_kde_plasma_window_request_resize
Comment 1 David Edmundson 2021-03-28 22:13:49 UTC
update your plasma-wayland-protocols
Comment 2 Eugene Shalygin 2021-03-28 22:21:48 UTC
Thank you! Could you, please, update build script in kwayland to bump required plasma-wayland-protocols version?