Bug 435060 - Notifications in the history lack interactive features that are in their pop-ups for KDE Connect
Summary: Notifications in the history lack interactive features that are in their pop-...
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: common (show other bugs)
Version: 1.10
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-28 11:46 UTC by Nico
Modified: 2021-08-12 18:47 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/network/kdeconnect-kde/-/commit/8d521540a87333906a51175c07756ca98b573e54
Version Fixed In: 21.08

Attachments
Notification in pop-up (20.73 KB, image/png)
2021-03-28 11:46 UTC, Nico 		Details
Notification in history (16.46 KB, image/png)
2021-03-28 11:46 UTC, Nico 		Details
Notification in pop-up on 21.03.90 (11.50 KB, image/png)
2021-04-09 22:36 UTC, Nico 		Details
Notification in history in 21.03.90 (13.46 KB, image/png)
2021-04-09 22:37 UTC, Nico 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nico 2021-03-28 11:46:00 UTC 
SUMMARY
Non-interactive notification in history

STEPS TO REPRODUCE
1. Setup KDE Connect with notification sync
2. Receive a notification with action buttons
3. Wait until it disappears
4. Open notifications plasmoid

OBSERVED RESULT
Buttons that were in the pop-up are now missing

EXPECTED RESULT
Buttons should be visible

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

Similar to https://bugs.kde.org/show_bug.cgi?id=407361
Comment 1 Nico 2021-03-28 11:46:26 UTC 
Created attachment 137125 [details]
Notification in pop-up
Comment 2 Nico 2021-03-28 11:46:36 UTC 
Created attachment 137126 [details]
Notification in history
Comment 3 Nate Graham 2021-03-31 17:45:34 UTC 
kdeconnect will need to adopt the new resident knotifications api that was added to support this. Here's how Discover did it: https://invent.kde.org/plasma/discover/-/commit/a01c7813b91406e4419a4eb43870b1698f7bf78e
Comment 4 Nico 2021-03-31 22:16:10 UTC 
@nate I double-checked and I think it was already added https://invent.kde.org/network/kdeconnect-kde/-/blob/master/plugins/notifications/notification.cpp#L95
So waiting for a new release 🥳
Comment 5 Nate Graham 2021-04-01 16:15:38 UTC 
Oh look, you're right! in that case this is already fixed. :)
Comment 6 Nico 2021-04-09 22:35:56 UTC 
I upgraded to 21.03.90 and the issue still persists
Comment 7 Nico 2021-04-09 22:36:56 UTC 
Created attachment 137457 [details]
Notification in pop-up on 21.03.90
Comment 8 Nico 2021-04-09 22:37:14 UTC 
Created attachment 137458 [details]
Notification in history in 21.03.90
Comment 9 Nicolas Fella 2021-04-09 22:43:49 UTC 
You also need Plasma 5.22 (the next release) for it to be effective
Comment 10 Nico 2021-04-09 22:47:19 UTC 
Oh sorry I didn't know that. Thanks for the clarification
Comment 11 Nico 2021-08-08 17:24:09 UTC 
I'm on Plasma 5.22.4, KDE Frameworks 5.84.0, KDE Connect 21.04.3 now and it still misses the buttons in the notifications applet
Comment 12 Nate Graham 2021-08-09 15:28:32 UTC 
Can confirm.
Comment 13 Nicolas Fella 2021-08-12 18:30:48 UTC 
(In reply to Nico from comment #11)
> I'm on Plasma 5.22.4, KDE Frameworks 5.84.0, KDE Connect 21.04.3 now and it
> still misses the buttons in the notifications applet

You need version 21.08
Comment 14 Nico 2021-08-12 18:34:24 UTC 
Oh, it was already set to fixed in 21.08, but I didn't pay attention to it. Thanks for clarifying, and sorry for the inconveniences
Comment 15 Nico 2021-08-12 18:47:21 UTC 
I can confirm that it works now with KDE Gear 21.08 ❤️🎉